Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 668793002: Make test_runner allow exclude_annotations along with test filters (Closed)

Created:
6 years, 2 months ago by mcdavid
Modified:
6 years, 2 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make test_runner allow exclude_annotations along with test filters When running android instrumentation tests through test_runner, the exclude_annotations rules will now take precedence over the test filters, instead of being ignored. BUG=425297 Committed: https://crrev.com/c4667365e4c28b4007ad9671bec4c3429e6238c2 Cr-Commit-Position: refs/heads/master@{#300486}

Patch Set 1 #

Patch Set 2 : Added myself to AUTHORS list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/instrumentation/test_jar.py View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
mcdavid
FYI: I'm currently not in the AUTHORS file. If this looks good to you, could ...
6 years, 2 months ago (2014-10-20 21:54:29 UTC) #2
jbudorick
On 2014/10/20 21:54:29, mcdavid wrote: > FYI: I'm currently not in the AUTHORS file. If ...
6 years, 2 months ago (2014-10-20 23:18:04 UTC) #3
jbudorick
On 2014/10/20 23:18:04, jbudorick wrote: > On 2014/10/20 21:54:29, mcdavid wrote: > > FYI: I'm ...
6 years, 2 months ago (2014-10-20 23:20:14 UTC) #4
mcdavid
I've added myself to the AUTHORS list, can you please add this to the CQ?
6 years, 2 months ago (2014-10-20 23:28:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668793002/20001
6 years, 2 months ago (2014-10-21 00:34:36 UTC) #7
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-21 02:37:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668793002/20001
6 years, 2 months ago (2014-10-21 13:55:37 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-21 14:46:34 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 14:47:16 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c4667365e4c28b4007ad9671bec4c3429e6238c2
Cr-Commit-Position: refs/heads/master@{#300486}

Powered by Google App Engine
This is Rietveld 408576698