Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 668783002: [chromedriver] Set mobile=true when calling setDeviceMetricsOverride (Closed)

Created:
6 years, 2 months ago by samuong
Modified:
6 years, 2 months ago
Reviewers:
stgao, srawlins
CC:
chromium-reviews, samuong+watch_chromium.org, stgao
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Set mobile=true when calling setDeviceMetricsOverride BUG=chromedriver:944 TBR=stgao@chromium.org Committed: https://crrev.com/02d008b0ee86ef7037833d27cf92b45f9125f097 Cr-Commit-Position: refs/heads/master@{#300390}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/test/chromedriver/chrome/device_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
srawlins
lgtm lgtm
6 years, 2 months ago (2014-10-20 21:54:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668783002/1
6 years, 2 months ago (2014-10-20 21:58:54 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-20 21:58:56 UTC) #6
stgao
lgtm
6 years, 2 months ago (2014-10-20 22:03:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668783002/1
6 years, 2 months ago (2014-10-20 22:03:25 UTC) #10
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-21 00:07:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668783002/1
6 years, 2 months ago (2014-10-21 00:36:57 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 00:38:35 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/02d008b0ee86ef7037833d27cf92b45f9125f097 Cr-Commit-Position: refs/heads/master@{#300390}
6 years, 2 months ago (2014-10-21 00:39:19 UTC) #16
samuong
6 years, 2 months ago (2014-10-21 15:51:49 UTC) #17
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/666173002/ by samuong@chromium.org.

The reason for reverting is: This is breaking mobile emulation tests
(testDeviceMetrics and testDeviceName). For some reason,
window.innerHeight/innerWidth get reported incorrectly when this patch is
applied..

Powered by Google App Engine
This is Rietveld 408576698