[Win] The new profiles UI: now at an immersive mode near you

chrome/browser/ui/webui/options/browser_options_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/browser_options_handler.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 1021 matching lines @@
   Profile* profile = Profile::FromWebUI(web_ui());
   return !profile->IsGuestSession();
 #endif
 }
 
 bool BrowserOptionsHandler::ShouldShowMultiProfilesUserList() {
 #if defined(OS_CHROMEOS)
   // On Chrome OS we use different UI for multi-profiles.
   return false;
 #else
-  if (helper::GetDesktopType(web_ui()) != chrome::HOST_DESKTOP_TYPE_NATIVE)
+  chrome::HostDesktopType desktop_type = helper::GetDesktopType(web_ui());
+  if (desktop_type != chrome::HOST_DESKTOP_TYPE_NATIVE &&

[msw, 2014/10/21 19:54:38]

What? I don't think there is any other desktop type besides native or ash...
afaict, this if statement will never evaluate to true.

[noms (inactive), 2014/10/21 20:55:18]

Oh, yeah, you're totally right. I misread that enum as having 4 values, but
that's a lie.

+      desktop_type != chrome::HOST_DESKTOP_TYPE_ASH) {
     return false;
+  }
   Profile* profile = Profile::FromWebUI(web_ui());
   if (profile->IsGuestSession())
     return false;
   return profiles::IsMultipleProfilesEnabled();
 #endif
 }
 
 bool BrowserOptionsHandler::ShouldAllowAdvancedSettings() {
 #if defined(OS_CHROMEOS)
   // ChromeOS handles guest-mode restrictions in a different manner.
@@ skipping 922 matching lines @@
 
 void BrowserOptionsHandler::SetMetricsReportingCheckbox(bool checked,
                                                         bool disabled) {
   web_ui()->CallJavascriptFunction(
       "BrowserOptions.setMetricsReportingCheckboxState",
       base::FundamentalValue(checked),
       base::FundamentalValue(disabled));
 }
 
 }  // namespace options