Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: tools/telemetry/telemetry/core/video.py

Issue 668753002: [Telemetry] Migrate bitmap.py from bitmaptools.cc to numpy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make GetBoundingBox just, like, WAY too fast Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/video.py
diff --git a/tools/telemetry/telemetry/core/video.py b/tools/telemetry/telemetry/core/video.py
index 4eb4cab3bbcf3714d1e69d18644de58d5c24ecd2..d7bf3e9139311ca028505bf62950e4663c20e984 100644
--- a/tools/telemetry/telemetry/core/video.py
+++ b/tools/telemetry/telemetry/core/video.py
@@ -18,8 +18,6 @@ class Video(object):
"""Utilities for storing and interacting with the video capture."""
def __init__(self, video_file_obj):
- assert video_file_obj.delete
- assert not video_file_obj.close_called
self._video_file_obj = video_file_obj
self._tab_contents_bounding_box = None
@@ -166,4 +164,5 @@ class Video(object):
raise StopIteration
assert num_read == len(frame_data), 'Unexpected frame size: %d' % num_read
yield (GetFrameTimestampMs(proc.stderr),
- bitmap.Bitmap(3, dimensions[0], dimensions[1], frame_data))
+ bitmap.Bitmap.FromRGBPixels(dimensions[0], dimensions[1],
+ frame_data, 3))

Powered by Google App Engine
This is Rietveld 408576698