Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: tools/testing/dart/compiler_configuration.dart

Issue 668743003: Clean up scripts to run Java-based analyzer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/bin/dartanalyzer_java.bat ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/compiler_configuration.dart
diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart
index b33f5549cfde0a91a3af01e900e259ca826e304a..668804a361ae5f852b267da6d1aa989aa6664a93 100644
--- a/tools/testing/dart/compiler_configuration.dart
+++ b/tools/testing/dart/compiler_configuration.dart
@@ -350,7 +350,7 @@ class AnalyzerCompilerConfiguration extends CompilerConfiguration {
String computeCompilerPath(String buildDir) {
String suffix = executableScriptSuffix;
- return 'sdk/bin/dartanalyzer_developer$suffix';
+ return 'sdk/bin/dartanalyzer_java$suffix';
}
CommandArtifact computeCompilationArtifact(
@@ -402,10 +402,7 @@ class DartBasedAnalyzerCompilerConfiguration
// The script dartanalyzer_developer is not included in the
// shipped SDK, that is the script is not installed in
// "$buildDir/dart-sdk/bin/"
- // TODO(paulberry): the script dartanalyzer_developer currently
- // points to the wrong place (the Java-based analyzer). Once
- // this is fixed, we should run dartanalyzer_developer when in
- // isHostChecked mode.
+ return '$prefix/dartanalyzer_developer$suffix';
}
if (useSdk) {
prefix = '$buildDir/dart-sdk/bin';
« no previous file with comments | « sdk/bin/dartanalyzer_java.bat ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698