Issue 668743002: Add Georgia, Verdana, and Trebuchet MS to fallback list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 668743002: Add Georgia, Verdana, and Trebuchet MS to fallback list (Closed)

Created:
6 years, 2 months ago by scottmg

Modified:
6 years, 2 months ago

Reviewers:
Shrikant Kelkar, ananta

CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Add Georgia, Verdana, and Trebuchet MS to fallback list When the number of font files exceeds 1750, we fallback to this list. Include Verdana, Georgia, and Trebuchet MS in this list until font loading is properly fixed. R=shrikant@chromium.org,ananta@chromium.org BUG=421305 Committed: https://crrev.com/deda0a559dd330692e3c12b20161a80460ddffd9 Cr-Commit-Position: refs/heads/master@{#300323}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	content/renderer/renderer_font_platform_win.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

ananta

LGTM. Maybe step back and figure out if using DirectWrite is the best approach for ...

6 years, 2 months ago (2014-10-20 19:05:44 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668743002/1

6 years, 2 months ago (2014-10-20 19:08:21 UTC) #4

commit-bot: I haz the power

6 years, 2 months ago (2014-10-20 20:38:43 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/deda0a559dd330692e3c12b20161a80460ddffd9
Cr-Commit-Position: refs/heads/master@{#300323}