Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 668683002: DevTools: remove style reuse from flamechart clients, prepare it to become a component. (Closed)

Created:
6 years, 2 months ago by pfeldman
Modified:
6 years, 2 months ago
Reviewers:
loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: remove style reuse from flamechart clients, prepare it to become a component. BUG=417275 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183990

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -37 lines) Patch
M Source/devtools/front_end/components/FlameChart.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/flameChart.css View 1 chunk +0 lines, -28 lines 0 comments Download
M Source/devtools/front_end/heapProfiler.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/profiler/CPUProfileFlameChart.js View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/devtools/front_end/profiler/HeapSnapshotView.js View 1 chunk +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/profilesPanel.css View 1 chunk +28 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
pfeldman
6 years, 2 months ago (2014-10-20 13:26:27 UTC) #2
loislo
lgtm
6 years, 2 months ago (2014-10-20 13:57:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668683002/1
6 years, 2 months ago (2014-10-20 13:58:11 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 14:58:38 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183990

Powered by Google App Engine
This is Rietveld 408576698