Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: mojo/edk/embedder/simple_platform_shared_buffer.h

Issue 668663006: Standardize usage of virtual/override/final in mojo/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/edk/embedder/simple_platform_shared_buffer.h
diff --git a/mojo/edk/embedder/simple_platform_shared_buffer.h b/mojo/edk/embedder/simple_platform_shared_buffer.h
index 110637e9100cd581d823203ffa6fd58122efa773..b4958b958ad45aacd721ed60e212327e7f59dd22 100644
--- a/mojo/edk/embedder/simple_platform_shared_buffer.h
+++ b/mojo/edk/embedder/simple_platform_shared_buffer.h
@@ -27,19 +27,18 @@ class MOJO_SYSTEM_IMPL_EXPORT SimplePlatformSharedBuffer
ScopedPlatformHandle platform_handle);
// |PlatformSharedBuffer| implementation:
- virtual size_t GetNumBytes() const override;
- virtual scoped_ptr<PlatformSharedBufferMapping> Map(size_t offset,
- size_t length) override;
- virtual bool IsValidMap(size_t offset, size_t length) override;
- virtual scoped_ptr<PlatformSharedBufferMapping> MapNoCheck(
- size_t offset,
- size_t length) override;
- virtual ScopedPlatformHandle DuplicatePlatformHandle() override;
- virtual ScopedPlatformHandle PassPlatformHandle() override;
+ size_t GetNumBytes() const override;
+ scoped_ptr<PlatformSharedBufferMapping> Map(size_t offset,
+ size_t length) override;
+ bool IsValidMap(size_t offset, size_t length) override;
+ scoped_ptr<PlatformSharedBufferMapping> MapNoCheck(size_t offset,
+ size_t length) override;
+ ScopedPlatformHandle DuplicatePlatformHandle() override;
+ ScopedPlatformHandle PassPlatformHandle() override;
private:
explicit SimplePlatformSharedBuffer(size_t num_bytes);
- virtual ~SimplePlatformSharedBuffer();
+ ~SimplePlatformSharedBuffer() override;
// Implemented in simple_platform_shared_buffer_{posix,win}.cc:
@@ -69,10 +68,10 @@ class MOJO_SYSTEM_IMPL_EXPORT SimplePlatformSharedBuffer
class MOJO_SYSTEM_IMPL_EXPORT SimplePlatformSharedBufferMapping
: public PlatformSharedBufferMapping {
public:
- virtual ~SimplePlatformSharedBufferMapping();
+ ~SimplePlatformSharedBufferMapping() override;
- virtual void* GetBase() const override;
- virtual size_t GetLength() const override;
+ void* GetBase() const override;
+ size_t GetLength() const override;
private:
friend class SimplePlatformSharedBuffer;
« no previous file with comments | « mojo/converters/input_events/mojo_extended_key_event_data.h ('k') | mojo/edk/embedder/simple_platform_support.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698