Issue 668603003: Mojo: mojob.sh: Add support for gn, and remove support for gyp and shared library (component) build…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 668603003: Mojo: mojob.sh: Add support for gn, and remove support for gyp and shared library (component) build… (Closed)

Created:
6 years, 2 months ago by viettrungluu

Modified:
6 years, 2 months ago

Reviewers:
jamesr

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mojo: mojob.sh: Add support for gn, and remove support for gyp and shared library (component) builds. R=jamesr@chromium.org Committed: https://crrev.com/12bd2826c0a32c319f893c7f3a16a7681eeaad23 Cr-Commit-Position: refs/heads/master@{#300371}

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -89 lines)			Patch
	M	mojo/tools/mojob.sh	View		7 chunks	+46 lines, -89 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668603003/1

6 years, 2 months ago (2014-10-20 21:54:38 UTC) #4

commit-bot: I haz the power

6 years, 2 months ago (2014-10-20 23:05:07 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/12bd2826c0a32c319f893c7f3a16a7681eeaad23
Cr-Commit-Position: refs/heads/master@{#300371}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages