Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 668573002: Return false in AcceleratorController::Process() if an accelerator has no effect (Closed)

Created:
6 years, 2 months ago by pkotwicz
Modified:
6 years, 2 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Return false in AcceleratorController::Process() if an accelerator has no effect This CL allows web pages to intercept the Ctrl+Shift+0 accelerator when no UI scaling is applied (which is the common case) BUG=404473 TEST=None Committed: https://crrev.com/7749fc5773c32fd67da38aa8f9e849fd14f4a64e Cr-Commit-Position: refs/heads/master@{#300370}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M ash/accelerators/accelerator_controller.cc View 5 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
pkotwicz
Oshima, can you please take a look? This is the first step in getting accelerators ...
6 years, 2 months ago (2014-10-19 19:17:55 UTC) #2
oshima
lgtm
6 years, 2 months ago (2014-10-20 19:10:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668573002/1
6 years, 2 months ago (2014-10-20 19:26:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/65629)
6 years, 2 months ago (2014-10-20 21:56:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668573002/1
6 years, 2 months ago (2014-10-20 22:16:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 22:52:03 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 22:52:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7749fc5773c32fd67da38aa8f9e849fd14f4a64e
Cr-Commit-Position: refs/heads/master@{#300370}

Powered by Google App Engine
This is Rietveld 408576698