Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 668543003: Use consistent types for leb128 decoder. (Closed)

Created:
6 years, 2 months ago by simonb (inactive)
Modified:
6 years, 2 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use consistent types for leb128 decoder. Use size_t throughout, and avoid mixing size_t and uint32_t. No behavioural effect. Unsigned leb128 is currently used only on 32-bit arm, and here uint32_t and size_t are equivalent. BUG=385553 Committed: https://crrev.com/7a2d857d70e8f38635dad6c183b87de1b3efa43a Cr-Commit-Position: refs/heads/master@{#301080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/android_crazy_linker/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/android_crazy_linker/src/src/crazy_linker_leb128.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
simonb (inactive)
6 years, 2 months ago (2014-10-23 17:44:18 UTC) #2
rmcilroy
lgtm, thanks.
6 years, 2 months ago (2014-10-24 09:41:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668543003/1
6 years, 2 months ago (2014-10-24 10:17:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-24 10:59:28 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 11:00:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a2d857d70e8f38635dad6c183b87de1b3efa43a
Cr-Commit-Position: refs/heads/master@{#301080}

Powered by Google App Engine
This is Rietveld 408576698