Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 6685112: Teach sandboxed GCC not to rely on inode numbers. (Closed)

Created:
9 years, 9 months ago by pasko-google - do not use
Modified:
9 years, 7 months ago
Reviewers:
khim, eaeltsin
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/git/nacl-gcc@master
Visibility:
Public.

Description

Teach sandboxed GCC not to rely on inode numbers. Inside the NaCl sandbox all inode numbers for files and directories are identical (because the least common denominator, Windows, does not have them). If GCC treats include directories (passed with -I) with identical inodes as identical directories. GCC then is free to skip looking into some directories for header files as an optimization. NaCl inodes are all identical, which makes GCC to only look into a single directory. Before we learn to emulate inode numbers on Windows, the sandboxed GCC would just not use this optimization. BUG=http://code.google.com/p/nativeclient/issues/detail?id=1362 TEST=none Committed: http://git.chromium.org/gitweb/?p=nacl-gcc.git;a=commit;h=22a67af

Patch Set 1 #

Patch Set 2 : emailed to reviewers #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : added TODO, fixed commenting style #

Patch Set 6 : rebased on top of master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -24 lines) Patch
M gcc/config/i386/nacl.h View 1 2 3 4 5 8 chunks +27 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pasko-google - do not use
9 years, 9 months ago (2011-03-20 19:21:28 UTC) #1
pasko-google - do not use
9 years, 9 months ago (2011-03-20 19:24:12 UTC) #2
pasko-google - do not use
9 years, 9 months ago (2011-03-20 19:24:47 UTC) #3
eaeltsin
lgtm If this is kinda temporary, please consider adding a TODO.
9 years, 9 months ago (2011-03-21 08:51:06 UTC) #4
pasko-google - do not use
9 years, 9 months ago (2011-03-21 09:28:18 UTC) #5
On 2011/03/21 08:51:06, Evgeny Eltsin wrote:
> lgtm
> 
> If this is kinda temporary, please consider adding a TODO.

Done.

Powered by Google App Engine
This is Rietveld 408576698