Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 6685095: Merge 78748 - net: fix blacklisted serial number. (Closed)

Created:
9 years, 9 months ago by agl
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Merge 78748 - net: fix blacklisted serial number. I made a mistake in r78478: one of the serial numbers was listed twice. BUG=none TEST=none TBR=agl@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78754

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/base/x509_certificate.cc View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 2 (0 generated)
agl
9 years, 9 months ago (2011-03-18 20:58:40 UTC) #1
jar (doing other things)
9 years, 9 months ago (2011-03-22 17:03:15 UTC) #2
Please see nit and suggestion for simplification below.

http://codereview.chromium.org/6685095/diff/1/net/base/x509_certificate.cc
File net/base/x509_certificate.cc (right):

http://codereview.chromium.org/6685095/diff/1/net/base/x509_certificate.cc#ne...
net/base/x509_certificate.cc:488:
{0xe9,0x02,0x8b,0x95,0x78,0xe4,0x15,0xdc,0x1a,0x71,0x0a,0x2b,0x88,0x15,0x44,0x47},
nit: Please wrap at 80 characters.

http://codereview.chromium.org/6685095/diff/1/net/base/x509_certificate.cc#ne...
net/base/x509_certificate.cc:500: 99 /* max */, 100 /* num buckets */);
For bucket size, you may as well set the size of the histogram to match the
number of serial numbers you have in the array.  This line would probably be
better written using:

UMA_HISTOGRAM_ENUMERATION("Net.SSLCertBlacklisted", i,  kNumSerials);

It will save memory... and will automatically grow if/when you add certificates.

You could probably also deduce the array size, kNumSerials rather than defining
it, but that is a personal style question.

Powered by Google App Engine
This is Rietveld 408576698