Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: views/view.h

Issue 6685069: Disambiguate OnMouseCaptureLost from OnMouseReleased, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments, fix tests, cleanup, etc. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « views/touchui/gesture_manager.cc ('k') | views/view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/view.h
diff --git a/views/view.h b/views/view.h
index e09f0beefc874ec995b1892433843988bdedba35..a560f4010ae7b4662a01a5f26395ade6c4719919 100644
--- a/views/view.h
+++ b/views/view.h
@@ -621,13 +621,14 @@ class View : public AcceleratorTarget {
// This method is invoked when the user releases the mouse
// button. The event is in the receiver's coordinate system.
//
- // If canceled is true it indicates the mouse press/drag was canceled by a
- // system/user gesture.
- //
// Default implementation notifies the ContextMenuController is appropriate.
// Subclasses that wish to honor the ContextMenuController should invoke
// super.
- virtual void OnMouseReleased(const MouseEvent& event, bool canceled);
+ virtual void OnMouseReleased(const MouseEvent& event);
+
+ // This method is invoked when the mouse press/drag was canceled by a
+ // system/user gesture.
+ virtual void OnMouseCaptureLost();
// This method is invoked when the mouse is above this control
// The event is in the receiver's coordinate system.
@@ -1230,7 +1231,7 @@ class View : public AcceleratorTarget {
// method. If a drag is detected, DoDrag is invoked.
bool ProcessMousePressed(const MouseEvent& event, DragInfo* drop_info);
bool ProcessMouseDragged(const MouseEvent& event, DragInfo* drop_info);
- void ProcessMouseReleased(const MouseEvent& event, bool canceled);
+ void ProcessMouseReleased(const MouseEvent& event);
#if defined(TOUCH_UI)
// RootView will invoke this with incoming TouchEvents. Returns the
« no previous file with comments | « views/touchui/gesture_manager.cc ('k') | views/view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698