views/controls/button/menu_button.h - Issue 6685069: Disambiguate OnMouseCaptureLost from OnMouseReleased, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: views/controls/button/menu_button.h

Issue 6685069: Disambiguate OnMouseCaptureLost from OnMouseReleased, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments, fix tests, cleanup, etc. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: views/controls/button/menu_button.h

diff --git a/views/controls/button/menu_button.h b/views/controls/button/menu_button.h

index b564b1c851dfad34658d8246c91c6bc119fd5c37..edab18b49f1de92800a632c8c9129ddd8bc3f78b 100644

--- a/views/controls/button/menu_button.h

+++ b/views/controls/button/menu_button.h

@@ -55,7 +55,7 @@ class MenuButton : public TextButton {

virtual gfx::Size GetPreferredSize() OVERRIDE;

virtual std::string GetClassName() const OVERRIDE;

virtual bool OnMousePressed(const MouseEvent& event) OVERRIDE;

- virtual void OnMouseReleased(const MouseEvent& event, bool canceled) OVERRIDE;

+ virtual void OnMouseReleased(const MouseEvent& event) OVERRIDE;

virtual void OnMouseExited(const MouseEvent& event) OVERRIDE;

virtual bool OnKeyPressed(const KeyEvent& event) OVERRIDE;

virtual bool OnKeyReleased(const KeyEvent& event) OVERRIDE;

« no previous file with comments | « views/controls/button/image_button.h ('k') | views/controls/button/menu_button.cc » ('j') | no next file with comments »