chrome/browser/ui/views/location_bar/star_view.h - Issue 6685069: Disambiguate OnMouseCaptureLost from OnMouseReleased, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/star_view.h

Issue 6685069: Disambiguate OnMouseCaptureLost from OnMouseReleased, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments, fix tests, cleanup, etc. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/location_bar/star_view.h

diff --git a/chrome/browser/ui/views/location_bar/star_view.h b/chrome/browser/ui/views/location_bar/star_view.h

index 678533696c2b427d37cd919a208a36c7d1de7ecb..ddd0cce8819edfb868c3080dde56706bf3103414 100644

--- a/chrome/browser/ui/views/location_bar/star_view.h

+++ b/chrome/browser/ui/views/location_bar/star_view.h

@@ -28,12 +28,11 @@ class StarView : public views::ImageView, public InfoBubbleDelegate {

private:

// views::ImageView overrides:

virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;

- virtual bool GetTooltipText(const gfx::Point& p, std::wstring* tooltip)

- OVERRIDE;

+ virtual bool GetTooltipText(const gfx::Point& p,

+ std::wstring* tooltip) OVERRIDE;

virtual bool OnMousePressed(const views::MouseEvent& event) OVERRIDE;

- virtual void OnMouseReleased(const views::MouseEvent& event, bool canceled)

- OVERRIDE;

- virtual bool OnKeyPressed(const views::KeyEvent& e) OVERRIDE;

+ virtual void OnMouseReleased(const views::MouseEvent& event) OVERRIDE;

+ virtual bool OnKeyPressed(const views::KeyEvent& event) OVERRIDE;

// InfoBubbleDelegate overrides:

virtual void InfoBubbleClosing(InfoBubble* info_bubble,