chrome/browser/ui/views/location_bar/location_icon_view.h - Issue 6685069: Disambiguate OnMouseCaptureLost from OnMouseReleased, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/location_icon_view.h

Issue 6685069: Disambiguate OnMouseCaptureLost from OnMouseReleased, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments, fix tests, cleanup, etc. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/location_bar/location_icon_view.h

diff --git a/chrome/browser/ui/views/location_bar/location_icon_view.h b/chrome/browser/ui/views/location_bar/location_icon_view.h

index 3bb80c79656cbf03412cfce55e9c704edd042af3..66a9d037944e0a234a630cda5ebcff71c8ac596b 100644

--- a/chrome/browser/ui/views/location_bar/location_icon_view.h

+++ b/chrome/browser/ui/views/location_bar/location_icon_view.h

@@ -23,8 +23,8 @@ class LocationIconView : public views::ImageView {

virtual ~LocationIconView();

// Overridden from views::ImageView:

- virtual bool OnMousePressed(const views::MouseEvent& event);

- virtual void OnMouseReleased(const views::MouseEvent& event, bool canceled);

+ virtual bool OnMousePressed(const views::MouseEvent& event) OVERRIDE;

+ virtual void OnMouseReleased(const views::MouseEvent& event) OVERRIDE;

// Whether we should show the tooltip for this icon or not.

void ShowTooltip(bool show);