chrome/browser/ui/views/location_bar/location_bar_view.h - Issue 6685069: Disambiguate OnMouseCaptureLost from OnMouseReleased, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.h

Issue 6685069: Disambiguate OnMouseCaptureLost from OnMouseReleased, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments, fix tests, cleanup, etc. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/location_bar/location_bar_view.h

diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.h b/chrome/browser/ui/views/location_bar/location_bar_view.h

index bb41badb86c06643d8f8a565e0bcc69c5ee2a4cd..cc05e2d103f3574dd2b1ecda425e2b3544cf5664 100644

--- a/chrome/browser/ui/views/location_bar/location_bar_view.h

+++ b/chrome/browser/ui/views/location_bar/location_bar_view.h

@@ -184,8 +184,8 @@ class LocationBarView : public LocationBar,

// Event Handlers

virtual bool OnMousePressed(const views::MouseEvent& event) OVERRIDE;

virtual bool OnMouseDragged(const views::MouseEvent& event) OVERRIDE;

- virtual void OnMouseReleased(const views::MouseEvent& event,

- bool canceled) OVERRIDE;

+ virtual void OnMouseReleased(const views::MouseEvent& event) OVERRIDE;

+ virtual void OnMouseCaptureLost() OVERRIDE;

#endif

const LocationIconView* location_icon_view() const {

@@ -209,7 +209,8 @@ class LocationBarView : public LocationBar,

// Overridden from views::View:

virtual std::string GetClassName() const OVERRIDE;

- virtual bool SkipDefaultKeyEventProcessing(const views::KeyEvent& e) OVERRIDE;

+ virtual bool SkipDefaultKeyEventProcessing(const views::KeyEvent& event)

+ OVERRIDE;

virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;

// Overridden from views::DragController: