chrome/browser/renderer_host/render_widget_host_view_views.cc - Issue 6685069: Disambiguate OnMouseCaptureLost from OnMouseReleased, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/render_widget_host_view_views.cc

Issue 6685069: Disambiguate OnMouseCaptureLost from OnMouseReleased, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments, fix tests, cleanup, etc. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/renderer_host/render_widget_host_view_views.cc

diff --git a/chrome/browser/renderer_host/render_widget_host_view_views.cc b/chrome/browser/renderer_host/render_widget_host_view_views.cc

index e848e0e87b7bdcd8a56c2a1f14c183048ad7abb4..977f87722c492d7f26c8cf5c61a1cb71cf949dc4 100644

--- a/chrome/browser/renderer_host/render_widget_host_view_views.cc

+++ b/chrome/browser/renderer_host/render_widget_host_view_views.cc

@@ -662,8 +662,8 @@ bool RenderWidgetHostViewViews::OnMouseDragged(const views::MouseEvent& event) {

return true;

}

-void RenderWidgetHostViewViews::OnMouseReleased(const views::MouseEvent& event,

- bool canceled) {

+void RenderWidgetHostViewViews::OnMouseReleased(

+ const views::MouseEvent& event) {

WebKit::WebMouseEvent e = WebMouseEventFromViewsEvent(event);

e.type = WebKit::WebInputEvent::MouseUp;