views/widget/widget_gtk.cc - Issue 6685069: Disambiguate OnMouseCaptureLost from OnMouseReleased, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: views/widget/widget_gtk.cc

Issue 6685069: Disambiguate OnMouseCaptureLost from OnMouseReleased, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address most TODOs and sync. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: views/widget/widget_gtk.cc

diff --git a/views/widget/widget_gtk.cc b/views/widget/widget_gtk.cc

index 1c3d5411e9d6e7c062b145764437aae8e58f5b89..ddcbe0c2eebe49ff3c4e5e228e299d2394521035 100644

--- a/views/widget/widget_gtk.cc

+++ b/views/widget/widget_gtk.cc

@@ -1272,7 +1272,7 @@ void WidgetGtk::HandleXGrabBroke() {

void WidgetGtk::HandleGtkGrabBroke() {

if (is_mouse_down_)

- GetRootView()->ProcessMouseDragCanceled();

+ GetRootView()->OnMouseCaptureLost();

is_mouse_down_ = false;

}

@@ -1343,7 +1343,7 @@ void WidgetGtk::ProcessMouseReleased(GdkEventButton* event) {

is_mouse_down_ = false;

// GTK generates a mouse release at the end of dnd. We need to ignore it.

if (!drag_data_)

- GetRootView()->OnMouseReleased(mouse_up, false);

+ GetRootView()->OnMouseReleased(mouse_up);

}

bool WidgetGtk::ProcessScroll(GdkEventScroll* event) {