Disambiguate OnMouseCaptureLost from OnMouseReleased, etc.

chrome/browser/renderer_host/render_widget_host_view_views.cc

Index: chrome/browser/renderer_host/render_widget_host_view_views.cc
diff --git a/chrome/browser/renderer_host/render_widget_host_view_views.cc b/chrome/browser/renderer_host/render_widget_host_view_views.cc
index 62236b6fe8f6555fec7f04ce28160ec044402a0f..74d87287a5d8fffd537ba7799a2c22bcb3d13d65 100644
--- a/chrome/browser/renderer_host/render_widget_host_view_views.cc
+++ b/chrome/browser/renderer_host/render_widget_host_view_views.cc
@@ -661,8 +661,8 @@ bool RenderWidgetHostViewViews::OnMouseDragged(const views::MouseEvent& event) {
   return true;
 }
 
-void RenderWidgetHostViewViews::OnMouseReleased(const views::MouseEvent& event,
-                                                bool canceled) {
+void RenderWidgetHostViewViews::OnMouseReleased(
+    const views::MouseEvent& event) {

[sadrul, 2011/03/19 09:15:30]

Merge lines 664-665 into one.

[msw, 2011/03/26 00:09:50]

That would be 81 characters :(

   WebKit::WebMouseEvent e = WebMouseEventFromViewsEvent(event);
 
   e.type = WebKit::WebInputEvent::MouseUp;
@@ -671,6 +671,10 @@ void RenderWidgetHostViewViews::OnMouseReleased(const views::MouseEvent& event,
   GetRenderWidgetHost()->ForwardMouseEvent(e);
 }
 
+void RenderWidgetHostViewViews::OnMouseCaptureLost() {
+  // TODO(msw): Replicate behavior of OnMouseReleased with synthesized event?

[sadrul, 2011/03/19 09:15:30]

Instead of duplicating the code in OnMouseReleased and OnMouseCaptureLost (here
and other places, for example PanelScrollerHeader), you could do either

(1) the default implementation (View::OnMouseCaptureLost) generates a synthetic
mouse-released event and invokes View::OnMouseReleased).

(2) View::OnMouseCaptureLost returns a bool, indicating whether a synthetic
MouseReleased event should be sent or not. RootView already creates such a
synthetic released event, so it can easily do (line root_view.cc:285):

if (!mouse_pressed_handler->OnMouseCaptureLost())
    mouse_pressed_handler->ProcessMouseReleased(...);

and the default (View::OnMouseCaptureLost) would return false.

[msw, 2011/03/26 00:09:50]

I removed this override altogether to parallel RenderWidgetHostViewWin, which
doesn't generate a MouseUp WebMouseEvent on mouse capture loss (event is
un-handled). As such, we can avoid complicating the framework to handle this
case.

+}
+
 void RenderWidgetHostViewViews::OnMouseMoved(const views::MouseEvent& event) {
   WebKit::WebMouseEvent e = WebMouseEventFromViewsEvent(event);