Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: views/controls/menu/menu_host_root_view.cc

Issue 6685069: Disambiguate OnMouseCaptureLost from OnMouseReleased, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments, fix tests, cleanup, etc. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « views/controls/menu/menu_host_root_view.h ('k') | views/controls/resize_area.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "views/controls/menu/menu_host_root_view.h" 5 #include "views/controls/menu/menu_host_root_view.h"
6 6
7 #include "views/controls/menu/menu_controller.h" 7 #include "views/controls/menu/menu_controller.h"
8 #include "views/controls/menu/submenu_view.h" 8 #include "views/controls/menu/submenu_view.h"
9 9
10 namespace views { 10 namespace views {
11 11
12 MenuHostRootView::MenuHostRootView(Widget* widget, 12 MenuHostRootView::MenuHostRootView(Widget* widget,
13 SubmenuView* submenu) 13 SubmenuView* submenu)
14 : RootView(widget), 14 : RootView(widget),
15 submenu_(submenu), 15 submenu_(submenu),
16 forward_drag_to_menu_controller_(true), 16 forward_drag_to_menu_controller_(true) {
17 suspend_events_(false) {
18 } 17 }
19 18
20 bool MenuHostRootView::OnMousePressed(const MouseEvent& event) { 19 bool MenuHostRootView::OnMousePressed(const MouseEvent& event) {
21 if (suspend_events_)
22 return true;
23
24 forward_drag_to_menu_controller_ = 20 forward_drag_to_menu_controller_ =
25 ((event.x() < 0 || event.y() < 0 || event.x() >= width() || 21 ((event.x() < 0 || event.y() < 0 || event.x() >= width() ||
26 event.y() >= height()) || 22 event.y() >= height()) ||
27 !RootView::OnMousePressed(event)); 23 !RootView::OnMousePressed(event));
28 if (forward_drag_to_menu_controller_ && GetMenuController()) 24 if (forward_drag_to_menu_controller_ && GetMenuController())
29 GetMenuController()->OnMousePressed(submenu_, event); 25 GetMenuController()->OnMousePressed(submenu_, event);
30 return true; 26 return true;
31 } 27 }
32 28
33 bool MenuHostRootView::OnMouseDragged(const MouseEvent& event) { 29 bool MenuHostRootView::OnMouseDragged(const MouseEvent& event) {
34 if (suspend_events_)
35 return true;
36
37 if (forward_drag_to_menu_controller_ && GetMenuController()) { 30 if (forward_drag_to_menu_controller_ && GetMenuController()) {
38 GetMenuController()->OnMouseDragged(submenu_, event); 31 GetMenuController()->OnMouseDragged(submenu_, event);
39 return true; 32 return true;
40 } 33 }
41 return RootView::OnMouseDragged(event); 34 return RootView::OnMouseDragged(event);
42 } 35 }
43 36
44 void MenuHostRootView::OnMouseReleased(const MouseEvent& event, 37 void MenuHostRootView::OnMouseReleased(const MouseEvent& event) {
45 bool canceled) { 38 RootView::OnMouseReleased(event);
46 if (suspend_events_)
47 return;
48
49 RootView::OnMouseReleased(event, canceled);
50 if (forward_drag_to_menu_controller_ && GetMenuController()) { 39 if (forward_drag_to_menu_controller_ && GetMenuController()) {
51 forward_drag_to_menu_controller_ = false; 40 forward_drag_to_menu_controller_ = false;
52 if (canceled) { 41 GetMenuController()->OnMouseReleased(submenu_, event);
53 GetMenuController()->Cancel(MenuController::EXIT_ALL);
54 } else {
55 GetMenuController()->OnMouseReleased(submenu_, event);
56 }
57 } 42 }
58 } 43 }
59 44
60 void MenuHostRootView::OnMouseMoved(const MouseEvent& event) { 45 void MenuHostRootView::OnMouseMoved(const MouseEvent& event) {
61 if (suspend_events_)
62 return;
63
64 RootView::OnMouseMoved(event); 46 RootView::OnMouseMoved(event);
65 if (GetMenuController()) 47 if (GetMenuController())
66 GetMenuController()->OnMouseMoved(submenu_, event); 48 GetMenuController()->OnMouseMoved(submenu_, event);
67 } 49 }
68 50
69 void MenuHostRootView::OnMouseExited(const MouseEvent& event) {
70 if (suspend_events_)
71 return;
72
73 RootView::OnMouseExited(event);
74 }
75
76 bool MenuHostRootView::OnMouseWheel(const MouseWheelEvent& event) { 51 bool MenuHostRootView::OnMouseWheel(const MouseWheelEvent& event) {
77 #if defined(OS_LINUX) 52 #if defined(OS_LINUX)
78 // ChromeOS uses MenuController to forward events like other 53 // ChromeOS uses MenuController to forward events like other
79 // mouse events. 54 // mouse events.
80 return GetMenuController() && 55 return GetMenuController() &&
81 GetMenuController()->OnMouseWheel(submenu_, event); 56 GetMenuController()->OnMouseWheel(submenu_, event);
82 #else 57 #else
83 // Windows uses focus_util_win::RerouteMouseWheel to forward events to 58 // Windows uses focus_util_win::RerouteMouseWheel to forward events to
84 // the right menu. 59 // the right menu.
85 // RootView::OnMouseWheel forwards to the focused view. We don't have a 60 // RootView::OnMouseWheel forwards to the focused view. We don't have a
86 // focused view, so we need to override this then forward to the menu. 61 // focused view, so we need to override this then forward to the menu.
87 return submenu_->OnMouseWheel(event); 62 return submenu_->OnMouseWheel(event);
88 #endif 63 #endif
89 } 64 }
90 65
91 MenuController* MenuHostRootView::GetMenuController() { 66 MenuController* MenuHostRootView::GetMenuController() {
92 return submenu_->GetMenuItem()->GetMenuController(); 67 return submenu_->GetMenuItem()->GetMenuController();
93 } 68 }
94 69
95 } // namespace views 70 } // namespace views
OLDNEW
« no previous file with comments | « views/controls/menu/menu_host_root_view.h ('k') | views/controls/resize_area.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698