Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: chrome/browser/ui/views/location_bar/ev_bubble_view.cc

Issue 6685069: Disambiguate OnMouseCaptureLost from OnMouseReleased, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments, fix tests, cleanup, etc. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/location_bar/ev_bubble_view.h" 5 #include "chrome/browser/ui/views/location_bar/ev_bubble_view.h"
6 6
7 EVBubbleView::EVBubbleView(const int background_images[], 7 EVBubbleView::EVBubbleView(const int background_images[],
8 int contained_image, 8 int contained_image,
9 const SkColor& color, 9 const SkColor& color,
10 LocationBarView* location_bar) 10 LocationBarView* location_bar)
11 : IconLabelBubbleView(background_images, contained_image, color), 11 : IconLabelBubbleView(background_images, contained_image, color),
12 ALLOW_THIS_IN_INITIALIZER_LIST(click_handler_(this, location_bar)) { 12 ALLOW_THIS_IN_INITIALIZER_LIST(click_handler_(this, location_bar)) {
13 SetElideInMiddle(true); 13 SetElideInMiddle(true);
14 } 14 }
15 15
16 EVBubbleView::~EVBubbleView() { 16 EVBubbleView::~EVBubbleView() {
17 } 17 }
18 18
19 bool EVBubbleView::OnMousePressed(const views::MouseEvent& event) { 19 bool EVBubbleView::OnMousePressed(const views::MouseEvent& event) {
20 // We want to show the dialog on mouse release; that is the standard behavior 20 // We want to show the dialog on mouse release; that is the standard behavior
21 // for buttons. 21 // for buttons.
22 return true; 22 return true;
23 } 23 }
24 24
25 void EVBubbleView::OnMouseReleased(const views::MouseEvent& event, 25 void EVBubbleView::OnMouseReleased(const views::MouseEvent& event) {
26 bool canceled) { 26 click_handler_.OnMouseReleased(event);
27 click_handler_.OnMouseReleased(event, canceled);
28 } 27 }
29
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/location_bar/ev_bubble_view.h ('k') | chrome/browser/ui/views/location_bar/icon_label_bubble_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698