Change mojo URLs from mojo://mojo_foo to mojo://foo.

Change mojo URLs from mojo://mojo_foo to mojo://foo.

The real changes are in mojo_url_resolver*.

The rest are renames that were generated with the following commands:

git grep -l 'mojo:mojo_' | xargs perl -pi -e 's|mojo:mojo_|mojo:|g'
git grep -l 'mojo://mojo_' | xargs perl -pi -e 's|mojo://mojo_|mojo://|g'
git cl format

Committed: https://crrev.com/194a8f4a17ff321718e646c63029155e7edf3a47
Cr-Commit-Position: refs/heads/master@{#300206}

[Aaron Boodman, 2014-10-18 02:56:01]

aa@chromium.org changed reviewers:
+ davemoore@chromium.org

[DaveMoore, 2014-10-18 04:10:53]

lgtm

[Aaron Boodman, 2014-10-18 04:42:45]

The CQ bit was checked by aa@chromium.org

[commit-bot: I haz the power, 2014-10-18 04:43:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/668483002/40001

[commit-bot: I haz the power, 2014-10-18 04:57:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-18 04:58:04]

Patchset 3 (id:??) landed as
https://crrev.com/194a8f4a17ff321718e646c63029155e7edf3a47
Cr-Commit-Position: refs/heads/master@{#300206}

[abarth-chromium, 2014-10-20 16:34:14]

abarth@chromium.org changed reviewers:
+ abarth@chromium.org

[abarth-chromium, 2014-10-20 16:34:15]

https://codereview.chromium.org/668483002/diff/40001/mojo/shell/mojo_url_reso...
File mojo/shell/mojo_url_resolver.cc (right):

https://codereview.chromium.org/668483002/diff/40001/mojo/shell/mojo_url_reso...
mojo/shell/mojo_url_resolver.cc:25: host_name = prefix + host_name;
This broke Sky because the sky targets are prefixed with sky_ rather than
mojo_...  I've renamed them to have a mojo_ prefix for now.  Is that the right
fix?

[darin (slow to review), 2014-10-20 16:37:46]

How about this:

We should probably change the build to put these DSOs in a special
directory (e.g., "apps") that mojo_shell expects to find alongside it.
Then, fix the build to not add a mojo_ or sky_ prefix to DSOs.

-Darin

On Mon, Oct 20, 2014 at 9:34 AM, <abarth@chromium.org> wrote:

>
> https://codereview.chromium.org/668483002/diff/40001/mojo/
> shell/mojo_url_resolver.cc
> File mojo/shell/mojo_url_resolver.cc (right):
>
> https://codereview.chromium.org/668483002/diff/40001/mojo/
> shell/mojo_url_resolver.cc#newcode25
> mojo/shell/mojo_url_resolver.cc:25: host_name = prefix + host_name;
> This broke Sky because the sky targets are prefixed with sky_ rather
> than mojo_...  I've renamed them to have a mojo_ prefix for now.  Is
> that the right fix?
>
> https://codereview.chromium.org/668483002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Aaron Boodman, 2014-10-20 17:53:00]

Sorry about that... I didn't see sky when I scanned the existing apps.

I think something like what Darin describes is right, but I also thought it
probably made sense to wait until after the repo changes to figure it out.

- a

On Mon, Oct 20, 2014 at 9:37 AM, Darin Fisher <darin@chromium.org> wrote:

> How about this:
>
> We should probably change the build to put these DSOs in a special
> directory (e.g., "apps") that mojo_shell expects to find alongside it.
> Then, fix the build to not add a mojo_ or sky_ prefix to DSOs.
>
> -Darin
>
> On Mon, Oct 20, 2014 at 9:34 AM, <abarth@chromium.org> wrote:
>
>>
>> https://codereview.chromium.org/668483002/diff/40001/mojo/
>> shell/mojo_url_resolver.cc
>> File mojo/shell/mojo_url_resolver.cc (right):
>>
>> https://codereview.chromium.org/668483002/diff/40001/mojo/
>> shell/mojo_url_resolver.cc#newcode25
>> mojo/shell/mojo_url_resolver.cc:25: host_name = prefix + host_name;
>> This broke Sky because the sky targets are prefixed with sky_ rather
>> than mojo_...  I've renamed them to have a mojo_ prefix for now.  Is
>> that the right fix?
>>
>> https://codereview.chromium.org/668483002/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[abarth-chromium, 2014-10-20 20:51:20]

On 2014/10/20 at 17:53:00, aa wrote:
> Sorry about that... I didn't see sky when I scanned the existing apps.

It's in a separate repo.

[Aaron Boodman, 2014-10-23 17:05:54]

I've removed the code that does the mojo_ prepending now, so you should be
able to change your binary name back to whatever you want.

Sorry for the churn.

- a

On Mon, Oct 20, 2014 at 1:51 PM, <abarth@chromium.org> wrote:

> On 2014/10/20 at 17:53:00, aa wrote:
>
>> Sorry about that... I didn't see sky when I scanned the existing apps.
>>
>
> It's in a separate repo.
>
>
> https://codereview.chromium.org/668483002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[abarth-chromium, 2014-10-23 17:33:25]

Thanks!