Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 668453003: Oilpan: Make InspectorInstrumentationCookie stack-allocated (Closed)

Created:
6 years, 2 months ago by haraken
Modified:
6 years, 2 months ago
Reviewers:
oilpan-reviews, keishi, sof
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Oilpan: Make InspectorInstrumentationCookie stack-allocated tiny-innerHTML.html allocates a ton of persistent handles in InspectorInstrumentationCookie(). I thought this might be a cause of the regression in tiny-innerHTML.html, but it wasn't. Thus this is just a cleanup CL. BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183940

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/core/inspector/InspectorInstrumentation.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
haraken
PTAL
6 years, 2 months ago (2014-10-18 06:08:45 UTC) #2
sof
lgtm
6 years, 2 months ago (2014-10-18 06:14:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668453003/1
6 years, 2 months ago (2014-10-18 06:16:29 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-18 08:20:49 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183940

Powered by Google App Engine
This is Rietveld 408576698