Issue 668443002: Changes HomeCard to fullscreen from bottom when typing a query.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 668443002: Changes HomeCard to fullscreen from bottom when typing a query. (Closed)

Created:
6 years, 2 months ago by Jun Mukai

Modified:
6 years, 2 months ago

Reviewers:
oshima

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master

Project:
chromium

Visibility:
Public.

Changes HomeCard to fullscreen from bottom when typing a query. BUG=424755 R=oshima@chromium.org TEST=manually && athena_unittests Committed: https://crrev.com/9867e691ad0d9c7bdb342093df2942a845117755 Cr-Commit-Position: refs/heads/master@{#300330}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -6 lines)			Patch
M	athena/home/athena_start_page_view.h	View	4 chunks	+11 lines, -0 lines	0 comments	Download
M	athena/home/athena_start_page_view.cc	View	3 chunks	+12 lines, -5 lines	0 comments	Download
M	athena/home/athena_start_page_view_unittest.cc	View	2 chunks	+18 lines, -0 lines	0 comments	Download
M	athena/home/home_card_impl.cc	View	3 chunks	+11 lines, -1 line	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668443002/1

6 years, 2 months ago (2014-10-20 19:41:43 UTC) #4

commit-bot: I haz the power

6 years, 2 months ago (2014-10-20 20:55:34 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9867e691ad0d9c7bdb342093df2942a845117755
Cr-Commit-Position: refs/heads/master@{#300330}