Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 668343002: Use fast_unwind_on_fatal=1 by default in ASan builds. (Closed)

Created:
6 years, 2 months ago by Alexander Potapenko
Modified:
6 years, 2 months ago
Reviewers:
inferno
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use fast_unwind_on_fatal=1 by default in ASan builds. This'll help us avoid crashes in the slow unwinder when unvinding through V8-generated code. BUG=422698 R=inferno@chromium.org NOTRY=true Committed: https://crrev.com/6744839e1f3d6c8abe49e685e9bfcb91c4abb154 Cr-Commit-Position: refs/heads/master@{#300780}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M build/sanitizers/sanitizer_options.cc View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Alexander Potapenko
PTAL
6 years, 2 months ago (2014-10-22 22:18:44 UTC) #1
inferno
lgtm
6 years, 2 months ago (2014-10-22 22:20:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668343002/1
6 years, 2 months ago (2014-10-22 22:24:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 22:26:15 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6744839e1f3d6c8abe49e685e9bfcb91c4abb154 Cr-Commit-Position: refs/heads/master@{#300780}
6 years, 2 months ago (2014-10-22 22:26:55 UTC) #6
Evgeniy Stepanov
On 2014/10/22 22:26:15, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) Do ...
6 years, 2 months ago (2014-10-22 22:26:56 UTC) #7
Alexander Potapenko
6 years, 2 months ago (2014-10-22 22:31:00 UTC) #8
Message was sent while issue was closed.
On 2014/10/22 22:26:56, Evgeniy Stepanov wrote:
> On 2014/10/22 22:26:15, I haz the power (commit-bot) wrote:
> > Committed patchset #1 (id:1)
> 
> Do we want this for TSan as well?
> Not for MSan, as that uses the V8 simulator.

Nope. TSan uses shadow stack for unwinding.

Powered by Google App Engine
This is Rietveld 408576698