Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 668303002: only define ARRAYSIZE_UNSAFE for NaCl builds (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

only define ARRAYSIZE_UNSAFE for NaCl builds Now that C++11 is allowed, we can use arraysize instead of ARRAYSIZE_UNSAFE, except in NaCl builds. So let's move this macro inside an NaCl ifdef. BUG=chromium:405225 LOG=y R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24875

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/base/macros.h View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mostyn Bramley-Moore
@jochen: PTAL.
6 years, 2 months ago (2014-10-23 21:14:14 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-23 21:16:28 UTC) #3
Sven Panne
Committed patchset #1 (id:1) manually as 24875 (presubmit successful).
6 years, 2 months ago (2014-10-24 13:21:24 UTC) #4
Nico
6 years, 1 month ago (2014-10-25 23:02:15 UTC) #6
Message was sent while issue was closed.
Out of interest, what goes wrong if you don't explicitly check for nacl? I
believe we want all our toolchains to be c++11-capable, and the nacl irt build
switched to building with the pnacl toolchain to achieve this. Which
configuration did we miss?

Powered by Google App Engine
This is Rietveld 408576698