Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 6683025: Make time_posix.cc build in Native Client... (Closed)

Created:
9 years, 9 months ago by abarth-chromium
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, eseidel, bbudge-google
Visibility:
Public.

Description

Make time_posix.cc build in Native Client Time handling in Native Client isn't quite as robust as on other posix systems. This patch adds a handful of ifdefs to work around these limitations. I've filed the underlying bugs with NaCl, but they aren't likely to be fixed until after NaCl switches to glibc. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77966

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M time_posix.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
This is a scaled-down version of http://codereview.chromium.org/5434001/
9 years, 9 months ago (2011-03-12 07:42:35 UTC) #1
brettw
LGTM
9 years, 9 months ago (2011-03-13 16:38:54 UTC) #2
abarth-chromium
9 years, 9 months ago (2011-03-13 19:00:04 UTC) #3
On 2011/03/13 16:38:54, brettw wrote:
> LGTM

Thanks!

Powered by Google App Engine
This is Rietveld 408576698