Issue 668208: Don't send form data that is marked autocomplete off to the browser....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 668208: Don't send form data that is marked autocomplete off to the browser.... (Closed)

Created:
10 years, 9 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins, jhawkins

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Don't send form data that is marked autocomplete off to the browser. Note that the test is run as a unit-test as RenderViewTest is buggy when run in-process. (submitting a form fails the second time you run it). By running it as a browser test, each unit-test is run into its own process. BUG=36277 TEST=See steps in bug. Also try the following steps: Create a page with a form withe the autocomplete="off" attribute. Enter some values submit. Reload the page, click the textfield in the form. Autocomplete should not be triggered. Modify the page and remove the autocomplete="off" attribute. Reload the page and click the textfield in the form, the autocomplete should still not be triggered (as the data you entered previously should not have been stored). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41074

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+132 lines, -2 lines)			Patch
M	chrome/chrome_tests.gypi	View	1 2 3	2 chunks	+6 lines, -0 lines	0 comments	Download
A	chrome/renderer/form_autocomplete_unittest.cc	View	3	1 chunk	+120 lines, -0 lines	0 comments	Download
M	webkit/glue/form_field_values.cc	View	1 2 3	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages

Issue 668208: Don't send form data that is marked autocomplete off to the browser.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages