Add Float64Round operator.

src/compiler/machine-operator.h

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_MACHINE_OPERATOR_H_
 #define V8_COMPILER_MACHINE_OPERATOR_H_
 
+#include "src/base/flags.h"
 #include "src/compiler/machine-type.h"
 
 namespace v8 {
 namespace internal {
 namespace compiler {
 
 // Forward declarations.
 struct MachineOperatorBuilderImpl;
 class Operator;
 
@@ skipping 26 matching lines @@
 
 bool operator==(StoreRepresentation, StoreRepresentation);
 bool operator!=(StoreRepresentation, StoreRepresentation);
 
 size_t hash_value(StoreRepresentation);
 
 std::ostream& operator<<(std::ostream&, StoreRepresentation);
 
 StoreRepresentation const& StoreRepresentationOf(Operator const*);
 
+// Rounding mode for double rounding.
+enum Float64RoundMode {
+  kRoundDown,

[titzer, 2014/10/22 14:05:42]

A little confusing here.

These rounding modes map to operators, correct? Then why do we need the separate
enum if it is not a parameter to the operator?

[sigurds, 2014/10/22 14:24:50]

I thought it was cleaner to have one op + rounding mode instead of several ops
here. Changed it in the last upload. Please tell me which you think is better.

+  kRoundUp,
+  kRoundAway,    // Rounding, tie: away from zero.
+  kRoundTowards  // Rounding, tie: towards zero.
+};
+
+#define BACKEND_SPECIFIC_OPS(V) \

[titzer, 2014/10/22 14:05:42]

Can we try to avoid the higher order macro stuff here? It's really hard to tell
what methods are available on the MachineOperatorBuilder like this.

[sigurds, 2014/10/22 14:24:50]

Done.

+  V(Float64Floor, 0)            \
+  V(Float64Ceil, 1)             \
+  V(Float64RoundTiesAway, 2)    \
+  V(Float64RoundTiesTowards, 3)
+
+enum SupportedOperator {
+  kNoSupportedOperators = 0
+#define ENUMDEF(Name, Ordinal) , kSupports##Name = 1 << Ordinal
+  BACKEND_SPECIFIC_OPS(ENUMDEF)
+#undef ENUMDEF
+};
+
+typedef base::Flags<SupportedOperator, uint8_t> SupportedOperators;
+DEFINE_OPERATORS_FOR_FLAGS(SupportedOperators)
 
 // Interface for building machine-level operators. These operators are
 // machine-level but machine-independent and thus define a language suitable
 // for generating code to run on architectures such as ia32, x64, arm, etc.
 class MachineOperatorBuilder FINAL {
  public:
-  explicit MachineOperatorBuilder(MachineType word = kMachPtr);
+  explicit MachineOperatorBuilder(
+      MachineType word = kMachPtr,
+      SupportedOperators supportedOperators = kNoSupportedOperators);
 
   const Operator* Word32And();
   const Operator* Word32Or();
   const Operator* Word32Xor();
   const Operator* Word32Shl();
   const Operator* Word32Shr();
   const Operator* Word32Sar();
   const Operator* Word32Ror();
   const Operator* Word32Equal();
 
@@ skipping 44 matching lines @@
   const Operator* ChangeInt32ToInt64();
   const Operator* ChangeUint32ToFloat64();
   const Operator* ChangeUint32ToUint64();
 
   // These operators truncate numbers, both changing the representation of
   // the number and mapping multiple input values onto the same output value.
   const Operator* TruncateFloat64ToFloat32();
   const Operator* TruncateFloat64ToInt32();  // JavaScript semantics.
   const Operator* TruncateInt64ToInt32();
 
+  // Rounds a number depending on rounding mode.
+  const Operator* Float64Round(Float64RoundMode mode);
+
   // Floating point operators always operate with IEEE 754 round-to-nearest.
   const Operator* Float64Add();
   const Operator* Float64Sub();
   const Operator* Float64Mul();
   const Operator* Float64Div();
   const Operator* Float64Mod();
   const Operator* Float64Sqrt();
 
   // Floating point comparisons complying to IEEE 754.
   const Operator* Float64Equal();
   const Operator* Float64LessThan();
   const Operator* Float64LessThanOrEqual();
 
   // load [base + index]
   const Operator* Load(LoadRepresentation rep);
 
   // store [base + index], value
   const Operator* Store(StoreRepresentation rep);
 
   // Access to the machine stack.
   const Operator* LoadStackPointer();
 
   // Target machine word-size assumed by this builder.
   bool Is32() const { return word() == kRepWord32; }
   bool Is64() const { return word() == kRepWord64; }
   MachineType word() const { return word_; }
 
+// Getters to test if backend specific operation is available.
+#define GETTER(Name, Ordinal) \
+  bool Has##Name() { return supportedOperators_ & kSupports##Name; }
+  BACKEND_SPECIFIC_OPS(GETTER)
+#undef GETTER
+
 // Pseudo operators that translate to 32/64-bit operators depending on the
 // word-size of the target machine assumed by this builder.
 #define PSEUDO_OP_LIST(V) \
   V(Word, And)            \
   V(Word, Or)             \
   V(Word, Xor)            \
   V(Word, Shl)            \
   V(Word, Shr)            \
   V(Word, Sar)            \
   V(Word, Ror)            \
@@ skipping 12 matching lines @@
   const Operator* Prefix##Suffix() {                             \
     return Is32() ? Prefix##32##Suffix() : Prefix##64##Suffix(); \
   }
   PSEUDO_OP_LIST(PSEUDO_OP)
 #undef PSEUDO_OP
 #undef PSEUDO_OP_LIST
 
  private:
   const MachineOperatorBuilderImpl& impl_;
   const MachineType word_;
+  const SupportedOperators supportedOperators_;
 };
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_MACHINE_OPERATOR_H_