Issue 668154: Inlining NumberIfFinite (ia32).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 668154: Inlining NumberIfFinite (ia32). (Closed)

Created:
10 years, 9 months ago by SeRya

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Inlining NumberIfFinite (ia32).

Patch Set 1 #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -1 line)			Patch
M	src/arm/codegen-arm.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/codegen.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/codegen-ia32.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1 chunk	+31 lines, -0 lines	1 comment	Download
M	src/mips/codegen-mips.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/mips/codegen-mips.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/v8natives.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/codegen-x64.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

10 years, 9 months ago (2010-03-08 12:00:48 UTC) #2

LGTM with comments

http://codereview.chromium.org/668154/diff/1/3
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/668154/diff/1/3#newcode6080
src/ia32/codegen-ia32.cc:6080: CpuFeatures::Scope use_cmov(CMOV);
If it makes sense to use cmov here then please implement the missing variant
taking a handle to avoid the additional move.

Expand Messages | Collapse Messages