src/compiler.cc - Issue 668143003: Move BailoutReason and flags computation to post-pass

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler.cc

Issue 668143003: Move BailoutReason and flags computation to post-pass (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix extraneous Renumber() call that crept back in Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler.cc

diff --git a/src/compiler.cc b/src/compiler.cc

index ad8325e9cff46119f69a69e4425e33608755debf..74ab1b0646fdf32d7ee8c9e53663df84725bded5 100644

--- a/src/compiler.cc

+++ b/src/compiler.cc

@@ -741,7 +741,10 @@ static void InsertCodeIntoOptimizedCodeMap(CompilationInfo* info) {

static bool Renumber(CompilationInfo* info) {

if (!AstNumbering::Renumber(info->function(), info->zone())) return false;

if (!info->shared_info().is_null()) {

- info->shared_info()->set_ast_node_count(info->function()->ast_node_count());

+ FunctionLiteral* lit = info->function();

+ info->shared_info()->set_ast_node_count(lit->ast_node_count());

+ info->shared_info()->set_bailout_reason(lit->dont_optimize_reason());

wingo 2014/10/27 15:08:20 As mstarzinger points out, this should probably be

+ info->shared_info()->set_dont_cache(lit->flags()->Contains(kDontCache));

}

return true;

}

« no previous file with comments | « src/ast-numbering.cc ('k') | src/parser.cc » ('j') | no next file with comments »