Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: src/ast.h

Issue 668143003: Move BailoutReason and flags computation to post-pass (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased on top of lgtm'd predecessor Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ast.cc » ('j') | src/compiler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast.h
diff --git a/src/ast.h b/src/ast.h
index 06b379ab0924c2e77882e44434a4dd7a39c9a3a4..b0d1166e21cc15f11f321f3e02fb6a595c4f0bb1 100644
--- a/src/ast.h
+++ b/src/ast.h
@@ -3115,17 +3115,9 @@ private: \
class AstConstructionVisitor BASE_EMBEDDED {
public:
- AstConstructionVisitor()
- : dont_crankshaft_reason_(kNoReason), dont_turbofan_reason_(kNoReason) {}
+ AstConstructionVisitor() {}
AstProperties* ast_properties() { return &properties_; }
- BailoutReason dont_optimize_reason() {
- if (dont_turbofan_reason_ != kNoReason) {
- return dont_turbofan_reason_;
- } else {
- return dont_crankshaft_reason_;
- }
- }
private:
template<class> friend class AstNodeFactory;
@@ -3136,14 +3128,6 @@ class AstConstructionVisitor BASE_EMBEDDED {
AST_NODE_LIST(DEF_VISIT)
#undef DEF_VISIT
- void add_flag(AstPropertiesFlag flag) { properties_.flags()->Add(flag); }
- void set_dont_crankshaft_reason(BailoutReason reason) {
- dont_crankshaft_reason_ = reason;
- }
- void set_dont_turbofan_reason(BailoutReason reason) {
- dont_turbofan_reason_ = reason;
- }
-
void add_slot_node(AstNode* slot_node) {
FeedbackVectorRequirements reqs = slot_node->ComputeFeedbackRequirements();
if (reqs.slots() > 0) {
@@ -3159,8 +3143,6 @@ class AstConstructionVisitor BASE_EMBEDDED {
}
AstProperties properties_;
- BailoutReason dont_crankshaft_reason_;
- BailoutReason dont_turbofan_reason_;
};
« no previous file with comments | « no previous file | src/ast.cc » ('j') | src/compiler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698