Issue 668123002: Autofill - Add regression test for multiple credit card fields

Issue 668123002: Autofill - Add regression test for multiple credit card fields (Closed)

Created:
6 years, 2 months ago by Evan Stade

Modified:
6 years, 2 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git/+/gdamnit

Project:
chromium

Visibility:
Public.

More Reviews

Description

Autofill - Add regression test for multiple credit card fields BUG=425256 Committed: https://crrev.com/b9cc2b26af0964d029fba9bfda5fd7a3bcb5d9b9 Cr-Commit-Position: refs/heads/master@{#300619}

Patch Set 1 #

Patch Set 2 : pare down input a bit #

Total comments: 9

Patch Set 3 : get rid of class=* and </head> #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2690 lines, -0 lines)			Patch
	A	chrome/test/data/autofill/heuristics/input/20_checkout_alaskaair.com.html	View	1 2	1 chunk	+2650 lines, -0 lines	0 comments	Download
	A	chrome/test/data/autofill/heuristics/output/20_checkout_alaskaair.com.out	View		1 chunk	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 11 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Ilya Sherman

Please trim the input file down to a smaller size. I typically rip out everything ...

6 years, 2 months ago (2014-10-21 22:36:00 UTC) #3

Evan Stade

I trimmed out a bit. Most of the page is inside the <form> though. The ...

6 years, 2 months ago (2014-10-21 23:30:24 UTC) #4

Ilya Sherman

LGTM with suggested additional cleanup. I've also noted a number of classification errors in this ...

6 years, 2 months ago (2014-10-21 23:50:54 UTC) #5

LGTM with suggested additional cleanup.  I've also noted a number of
classification errors in this test file.  Might be worth investigating the
causes of these (as follow-up bugs/CLs, of course).

https://codereview.chromium.org/668123002/diff/20001/chrome/test/data/autofil...
File chrome/test/data/autofill/heuristics/input/20_checkout_alaskaair.com.html
(right):

https://codereview.chromium.org/668123002/diff/20001/chrome/test/data/autofil...
chrome/test/data/autofill/heuristics/input/20_checkout_alaskaair.com.html:3:
<html class=" js flexbox flexboxlegacy canvas canvastext webgl no-touch
geolocation postmessage websqldatabase indexeddb hashchange history draganddrop
websockets rgba hsla multiplebgs backgroundsize borderimage borderradius
boxshadow textshadow opacity cssanimations csscolumns cssgradients
cssreflections csstransforms csstransforms3d csstransitions fontface
generatedcontent video audio localstorage sessionstorage webworkers
applicationcache svg inlinesvg smil svgclippaths"><head><meta
http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
I'd remove all class="*" attributes.

https://codereview.chromium.org/668123002/diff/20001/chrome/test/data/autofil...
chrome/test/data/autofill/heuristics/input/20_checkout_alaskaair.com.html:11:
</head>
I'd remove the <head>, as it's not relevant.

https://codereview.chromium.org/668123002/diff/20001/chrome/test/data/autofil...
File chrome/test/data/autofill/heuristics/output/20_checkout_alaskaair.com.out
(right):

https://codereview.chromium.org/668123002/diff/20001/chrome/test/data/autofil...
chrome/test/data/autofill/heuristics/output/20_checkout_alaskaair.com.out:7:
UNKNOWN_TYPE | CreditCardInformation.BillingCreditCardEntry.CardTypes_Selected |
Card Type* | CreditCard
Note: Surprising this is of unknown type.

https://codereview.chromium.org/668123002/diff/20001/chrome/test/data/autofil...
chrome/test/data/autofill/heuristics/output/20_checkout_alaskaair.com.out:11:
UNKNOWN_TYPE |
CreditCardInformation.BillingCreditCardEntry.ExpirationYears_Selected |
Expiration* |
These too.

https://codereview.chromium.org/668123002/diff/20001/chrome/test/data/autofil...
chrome/test/data/autofill/heuristics/output/20_checkout_alaskaair.com.out:20:
UNKNOWN_TYPE | CreditCardInformation.BillingAddressEntry.OtherStates_Selected |
State/Province |
A bit surprising this is not detected.

https://codereview.chromium.org/668123002/diff/20001/chrome/test/data/autofil...
chrome/test/data/autofill/heuristics/output/20_checkout_alaskaair.com.out:22:
ADDRESS_HOME_COUNTRY |
CreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected | Country
Code | 1
This is misclassified -- should be a phone number field.

https://codereview.chromium.org/668123002/diff/20001/chrome/test/data/autofil...
chrome/test/data/autofill/heuristics/output/20_checkout_alaskaair.com.out:37:
UNKNOWN_TYPE |
AncillaryCreditCardInformation.BillingAddressEntry.OtherStates_Selected |
State/Province |
A bit surprising this is not detected.

https://codereview.chromium.org/668123002/diff/20001/chrome/test/data/autofil...
chrome/test/data/autofill/heuristics/output/20_checkout_alaskaair.com.out:39:
ADDRESS_HOME_COUNTRY |
AncillaryCreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected |
Country Code | 1
This is misclassified -- should be a phone number field.

Evan Stade

On 2014/10/21 23:50:54, Ilya Sherman wrote: > LGTM with suggested additional cleanup. I've also noted ...

6 years, 2 months ago (2014-10-22 00:01:44 UTC) #6

On 2014/10/21 23:50:54, Ilya Sherman wrote:
> LGTM with suggested additional cleanup.  I've also noted a number of
> classification errors in this test file.  Might be worth investigating the
> causes of these (as follow-up bugs/CLs, of course).
> 
>
https://codereview.chromium.org/668123002/diff/20001/chrome/test/data/autofil...
> File chrome/test/data/autofill/heuristics/input/20_checkout_alaskaair.com.html
> (right):
> 
>
https://codereview.chromium.org/668123002/diff/20001/chrome/test/data/autofil...
> chrome/test/data/autofill/heuristics/input/20_checkout_alaskaair.com.html:3:
> <html class=" js flexbox flexboxlegacy canvas canvastext webgl no-touch
> geolocation postmessage websqldatabase indexeddb hashchange history
draganddrop
> websockets rgba hsla multiplebgs backgroundsize borderimage borderradius
> boxshadow textshadow opacity cssanimations csscolumns cssgradients
> cssreflections csstransforms csstransforms3d csstransitions fontface
> generatedcontent video audio localstorage sessionstorage webworkers
> applicationcache svg inlinesvg smil svgclippaths"><head><meta
> http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
> I'd remove all class="*" attributes.
> 
>
https://codereview.chromium.org/668123002/diff/20001/chrome/test/data/autofil...
> chrome/test/data/autofill/heuristics/input/20_checkout_alaskaair.com.html:11:
> </head>
> I'd remove the <head>, as it's not relevant.
> 
>
https://codereview.chromium.org/668123002/diff/20001/chrome/test/data/autofil...
> File chrome/test/data/autofill/heuristics/output/20_checkout_alaskaair.com.out
> (right):
> 
>
https://codereview.chromium.org/668123002/diff/20001/chrome/test/data/autofil...
> chrome/test/data/autofill/heuristics/output/20_checkout_alaskaair.com.out:7:
> UNKNOWN_TYPE | CreditCardInformation.BillingCreditCardEntry.CardTypes_Selected
|
> Card Type* | CreditCard
> Note: Surprising this is of unknown type.
> 
>
https://codereview.chromium.org/668123002/diff/20001/chrome/test/data/autofil...
> chrome/test/data/autofill/heuristics/output/20_checkout_alaskaair.com.out:11:
> UNKNOWN_TYPE |
> CreditCardInformation.BillingCreditCardEntry.ExpirationYears_Selected |
> Expiration* |
> These too.
> 
>
https://codereview.chromium.org/668123002/diff/20001/chrome/test/data/autofil...
> chrome/test/data/autofill/heuristics/output/20_checkout_alaskaair.com.out:20:
> UNKNOWN_TYPE | CreditCardInformation.BillingAddressEntry.OtherStates_Selected
|
> State/Province |
> A bit surprising this is not detected.
> 
>
https://codereview.chromium.org/668123002/diff/20001/chrome/test/data/autofil...
> chrome/test/data/autofill/heuristics/output/20_checkout_alaskaair.com.out:22:
> ADDRESS_HOME_COUNTRY |
> CreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected | Country
> Code | 1
> This is misclassified -- should be a phone number field.
> 
>
https://codereview.chromium.org/668123002/diff/20001/chrome/test/data/autofil...
> chrome/test/data/autofill/heuristics/output/20_checkout_alaskaair.com.out:37:
> UNKNOWN_TYPE |
> AncillaryCreditCardInformation.BillingAddressEntry.OtherStates_Selected |
> State/Province |
> A bit surprising this is not detected.
> 
>
https://codereview.chromium.org/668123002/diff/20001/chrome/test/data/autofil...
> chrome/test/data/autofill/heuristics/output/20_checkout_alaskaair.com.out:39:
> ADDRESS_HOME_COUNTRY |
> AncillaryCreditCardInformation.BillingPhoneNumberEntry.CountryCode_Selected |
> Country Code | 1
> This is misclassified -- should be a phone number field.

thanks for the comments --- filed crbug.com/425818

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668123002/40001

6 years, 2 months ago (2014-10-22 00:05:21 UTC) #8

commit-bot: I haz the power

Patchset 3 (id:??) landed as https://crrev.com/b9cc2b26af0964d029fba9bfda5fd7a3bcb5d9b9 Cr-Commit-Position: refs/heads/master@{#300619}

6 years, 2 months ago (2014-10-22 04:05:25 UTC) #10

Evan Stade

6 years, 2 months ago (2014-10-23 00:15:16 UTC) #11

Message was sent while issue was closed.

https://codereview.chromium.org/668123002/diff/20001/chrome/test/data/autofil...
File chrome/test/data/autofill/heuristics/output/20_checkout_alaskaair.com.out
(right):

https://codereview.chromium.org/668123002/diff/20001/chrome/test/data/autofil...
chrome/test/data/autofill/heuristics/output/20_checkout_alaskaair.com.out:7:
UNKNOWN_TYPE | CreditCardInformation.BillingCreditCardEntry.CardTypes_Selected |
Card Type* | CreditCard
On 2014/10/21 23:50:54, Ilya Sherman wrote:
> Note: Surprising this is of unknown type.

This is right to be UNKNOWN. It's a radio where the two options are:

- Visa, MC, AmEx, etc.
- Alaska Airlines commercial account

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages