Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1744)

Unified Diff: Source/core/svg/SVGFEDisplacementMapElement.cpp

Issue 668113003: SVGElement::parseAttribute resolves property via property map (Step 2.6) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGFEDiffuseLightingElement.cpp ('k') | Source/core/svg/SVGFETileElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGFEDisplacementMapElement.cpp
diff --git a/Source/core/svg/SVGFEDisplacementMapElement.cpp b/Source/core/svg/SVGFEDisplacementMapElement.cpp
index d8d9f4d85d01f18956e0d04cbfe4603e6248a1f2..b1f8f3ce34f3049a1bcbf54d79733a00a3035855 100644
--- a/Source/core/svg/SVGFEDisplacementMapElement.cpp
+++ b/Source/core/svg/SVGFEDisplacementMapElement.cpp
@@ -71,27 +71,7 @@ bool SVGFEDisplacementMapElement::isSupportedAttribute(const QualifiedName& attr
void SVGFEDisplacementMapElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
{
- if (!isSupportedAttribute(name)) {
- SVGFilterPrimitiveStandardAttributes::parseAttribute(name, value);
- return;
- }
-
- SVGParsingError parseError = NoError;
-
- if (name == SVGNames::inAttr)
- m_in1->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::in2Attr)
- m_in2->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::scaleAttr)
- m_scale->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::xChannelSelectorAttr)
- m_xChannelSelector->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::yChannelSelectorAttr)
- m_yChannelSelector->setBaseValueAsString(value, parseError);
- else
- ASSERT_NOT_REACHED();
-
- reportAttributeParsingError(parseError, name, value);
+ parseAttributeNew(name, value);
}
bool SVGFEDisplacementMapElement::setFilterEffectAttribute(FilterEffect* effect, const QualifiedName& attrName)
« no previous file with comments | « Source/core/svg/SVGFEDiffuseLightingElement.cpp ('k') | Source/core/svg/SVGFETileElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698