Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Unified Diff: Source/core/svg/SVGFECompositeElement.cpp

Issue 668113003: SVGElement::parseAttribute resolves property via property map (Step 2.6) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/svg/SVGFEConvolveMatrixElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGFECompositeElement.cpp
diff --git a/Source/core/svg/SVGFECompositeElement.cpp b/Source/core/svg/SVGFECompositeElement.cpp
index 7f4c284ce028ac2d52d37f246a3490b0a2196f90..510b72053c4f05126797e7e3d96a8c09c402fb78 100644
--- a/Source/core/svg/SVGFECompositeElement.cpp
+++ b/Source/core/svg/SVGFECompositeElement.cpp
@@ -80,31 +80,7 @@ bool SVGFECompositeElement::isSupportedAttribute(const QualifiedName& attrName)
void SVGFECompositeElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
{
- if (!isSupportedAttribute(name)) {
- SVGFilterPrimitiveStandardAttributes::parseAttribute(name, value);
- return;
- }
-
- SVGParsingError parseError = NoError;
-
- if (name == SVGNames::inAttr)
- m_in1->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::in2Attr)
- m_in2->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::k1Attr)
- m_k1->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::k2Attr)
- m_k2->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::k3Attr)
- m_k3->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::k4Attr)
- m_k4->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::operatorAttr)
- m_svgOperator->setBaseValueAsString(value, parseError);
- else
- ASSERT_NOT_REACHED();
-
- reportAttributeParsingError(parseError, name, value);
+ parseAttributeNew(name, value);
}
bool SVGFECompositeElement::setFilterEffectAttribute(FilterEffect* effect, const QualifiedName& attrName)
« no previous file with comments | « no previous file | Source/core/svg/SVGFEConvolveMatrixElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698