Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6517)

Unified Diff: chrome/browser/printing/print_preview_pdf_generated_browsertest.cc

Issue 668093002: Standardize usage of virtual/override/final in chrome/browser/printing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/print_preview_pdf_generated_browsertest.cc
diff --git a/chrome/browser/printing/print_preview_pdf_generated_browsertest.cc b/chrome/browser/printing/print_preview_pdf_generated_browsertest.cc
index bd93dc2cf45678d16098e9aad4326f6bbec9aba4..646f954ea63641c7787f71df80a8a6da38ded332 100644
--- a/chrome/browser/printing/print_preview_pdf_generated_browsertest.cc
+++ b/chrome/browser/printing/print_preview_pdf_generated_browsertest.cc
@@ -118,7 +118,7 @@ class PrintPreviewObserver : public WebContentsObserver {
failed_setting_("None"),
pdf_file_save_path_(pdf_file_save_path) {}
- virtual ~PrintPreviewObserver() {}
+ ~PrintPreviewObserver() override {}
// Sets closure for the observer so that it can end the loop.
void set_quit_closure(const base::Closure &closure) {
@@ -130,7 +130,7 @@ class PrintPreviewObserver : public WebContentsObserver {
base::MessageLoop::current()->PostTask(FROM_HERE, quit_closure_);
}
- virtual bool OnMessageReceived(const IPC::Message& message) override {
+ bool OnMessageReceived(const IPC::Message& message) override {
IPC_BEGIN_MESSAGE_MAP(PrintPreviewObserver, message)
IPC_MESSAGE_HANDLER(PrintHostMsg_DidGetPreviewPageCount,
OnDidGetPreviewPageCount)
@@ -222,7 +222,7 @@ class PrintPreviewObserver : public WebContentsObserver {
explicit UIDoneLoadingMessageHandler(PrintPreviewObserver* observer)
: observer_(observer) {}
- virtual ~UIDoneLoadingMessageHandler() {}
+ ~UIDoneLoadingMessageHandler() override {}
// When a setting has been set succesfully, this is called and the observer
// is told to send the next setting to be set.
@@ -242,7 +242,7 @@ class PrintPreviewObserver : public WebContentsObserver {
// successfully set and its effects have been finalized.
// 'UIFailedLoadingForTest' is sent when the setting could not be set. This
// causes the browser test to fail.
- virtual void RegisterMessages() override {
+ void RegisterMessages() override {
web_ui()->RegisterMessageCallback(
"UILoadedForTest",
base::Bind(&UIDoneLoadingMessageHandler::HandleDone,
@@ -277,9 +277,8 @@ class PrintPreviewObserver : public WebContentsObserver {
ui->web_ui()->CallJavascriptFunction("onEnableManipulateSettingsForTest");
}
- virtual void DidCloneToNewWebContents(
- WebContents* old_web_contents,
- WebContents* new_web_contents) override {
+ void DidCloneToNewWebContents(WebContents* old_web_contents,
+ WebContents* new_web_contents) override {
Observe(new_web_contents);
}
« no previous file with comments | « chrome/browser/printing/print_preview_message_handler.h ('k') | chrome/browser/printing/print_preview_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698