Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1533)

Unified Diff: chrome/browser/printing/print_preview_dialog_controller_browsertest.cc

Issue 668093002: Standardize usage of virtual/override/final in chrome/browser/printing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/print_preview_dialog_controller_browsertest.cc
diff --git a/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc b/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc
index 48711126c493740a65f718b7d7dbdc39fa15afcd..facedba11f5c9294c29b47b27d7ee59be0c048c5 100644
--- a/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc
+++ b/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc
@@ -25,7 +25,7 @@ class RequestPrintPreviewObserver : public WebContentsObserver {
explicit RequestPrintPreviewObserver(WebContents* dialog)
: WebContentsObserver(dialog) {
}
- virtual ~RequestPrintPreviewObserver() {}
+ ~RequestPrintPreviewObserver() override {}
void set_quit_closure(const base::Closure& quit_closure) {
quit_closure_ = quit_closure;
@@ -33,7 +33,7 @@ class RequestPrintPreviewObserver : public WebContentsObserver {
private:
// content::WebContentsObserver implementation.
- virtual bool OnMessageReceived(const IPC::Message& message) override {
+ bool OnMessageReceived(const IPC::Message& message) override {
IPC_BEGIN_MESSAGE_MAP(RequestPrintPreviewObserver, message)
IPC_MESSAGE_HANDLER(PrintHostMsg_RequestPrintPreview,
OnRequestPrintPreview)
@@ -57,7 +57,7 @@ class PrintPreviewDialogClonedObserver : public WebContentsObserver {
explicit PrintPreviewDialogClonedObserver(WebContents* dialog)
: WebContentsObserver(dialog) {
}
- virtual ~PrintPreviewDialogClonedObserver() {}
+ ~PrintPreviewDialogClonedObserver() override {}
RequestPrintPreviewObserver* request_preview_dialog_observer() {
return request_preview_dialog_observer_.get();
@@ -65,9 +65,8 @@ class PrintPreviewDialogClonedObserver : public WebContentsObserver {
private:
// content::WebContentsObserver implementation.
- virtual void DidCloneToNewWebContents(
- WebContents* old_web_contents,
- WebContents* new_web_contents) override {
+ void DidCloneToNewWebContents(WebContents* old_web_contents,
+ WebContents* new_web_contents) override {
request_preview_dialog_observer_.reset(
new RequestPrintPreviewObserver(new_web_contents));
}
@@ -83,15 +82,13 @@ class PrintPreviewDialogDestroyedObserver : public WebContentsObserver {
: WebContentsObserver(dialog),
dialog_destroyed_(false) {
}
- virtual ~PrintPreviewDialogDestroyedObserver() {}
+ ~PrintPreviewDialogDestroyedObserver() override {}
bool dialog_destroyed() const { return dialog_destroyed_; }
private:
// content::WebContentsObserver implementation.
- virtual void WebContentsDestroyed() override {
- dialog_destroyed_ = true;
- }
+ void WebContentsDestroyed() override { dialog_destroyed_ = true; }
bool dialog_destroyed_;
@@ -121,7 +118,7 @@ class PrintPreviewDialogControllerBrowserTest : public InProcessBrowserTest {
}
private:
- virtual void SetUpOnMainThread() override {
+ void SetUpOnMainThread() override {
WebContents* first_tab =
browser()->tab_strip_model()->GetActiveWebContents();
ASSERT_TRUE(first_tab);
@@ -139,7 +136,7 @@ class PrintPreviewDialogControllerBrowserTest : public InProcessBrowserTest {
ASSERT_NE(first_tab, initiator_);
}
- virtual void TearDownOnMainThread() override {
+ void TearDownOnMainThread() override {
cloned_tab_observer_.reset();
initiator_ = NULL;
}
« no previous file with comments | « chrome/browser/printing/print_preview_dialog_controller.cc ('k') | chrome/browser/printing/print_preview_message_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698