Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3259)

Unified Diff: chrome/browser/printing/print_job.h

Issue 668093002: Standardize usage of virtual/override/final in chrome/browser/printing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/printing/print_dialog_cloud_internal.h ('k') | chrome/browser/printing/print_job_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_job.h
diff --git a/chrome/browser/printing/print_job.h b/chrome/browser/printing/print_job.h
index ae22e9825a53547e222780aac9c76521e957e54f..c468bbd390cd40b18089383f0f16bbaadb15adde 100644
--- a/chrome/browser/printing/print_job.h
+++ b/chrome/browser/printing/print_job.h
@@ -49,16 +49,16 @@ class PrintJob : public PrintJobWorkerOwner,
int page_count);
// content::NotificationObserver implementation.
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override;
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override;
// PrintJobWorkerOwner implementation.
- virtual void GetSettingsDone(const PrintSettings& new_settings,
- PrintingContext::Result result) override;
- virtual PrintJobWorker* DetachWorker(PrintJobWorkerOwner* new_owner) override;
- virtual const PrintSettings& settings() const override;
- virtual int cookie() const override;
+ void GetSettingsDone(const PrintSettings& new_settings,
+ PrintingContext::Result result) override;
+ PrintJobWorker* DetachWorker(PrintJobWorkerOwner* new_owner) override;
+ const PrintSettings& settings() const override;
+ int cookie() const override;
// Starts the actual printing. Signals the worker that it should begin to
// spool as soon as data is available.
@@ -98,7 +98,7 @@ class PrintJob : public PrintJobWorkerOwner,
#endif // OS_WIN
protected:
- virtual ~PrintJob();
+ ~PrintJob() override;
private:
// Updates document_ to a new instance.
« no previous file with comments | « chrome/browser/printing/print_dialog_cloud_internal.h ('k') | chrome/browser/printing/print_job_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698