chrome/browser/printing/cloud_print/cloud_print_proxy_service_factory.h - Issue 668093002: Standardize usage of virtual/override/final in chrome/browser/printing/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/cloud_print/cloud_print_proxy_service_factory.h

Issue 668093002: Standardize usage of virtual/override/final in chrome/browser/printing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/cloud_print/cloud_print_proxy_service.h ('k') | chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/cloud_print/cloud_print_proxy_service_factory.h

diff --git a/chrome/browser/printing/cloud_print/cloud_print_proxy_service_factory.h b/chrome/browser/printing/cloud_print/cloud_print_proxy_service_factory.h

index d8c687726ec46a071197e5b0994a571b32c26ce2..c14e04d95813fa57d0fed0fa4147310a440865aa 100644

--- a/chrome/browser/printing/cloud_print/cloud_print_proxy_service_factory.h

+++ b/chrome/browser/printing/cloud_print/cloud_print_proxy_service_factory.h

@@ -27,12 +27,12 @@ class CloudPrintProxyServiceFactory : public BrowserContextKeyedServiceFactory {

friend struct DefaultSingletonTraits<CloudPrintProxyServiceFactory>;

CloudPrintProxyServiceFactory();

- virtual ~CloudPrintProxyServiceFactory();

+ ~CloudPrintProxyServiceFactory() override;

// BrowserContextKeyedServiceFactory:

- virtual KeyedService* BuildServiceInstanceFor(

+ KeyedService* BuildServiceInstanceFor(

content::BrowserContext* profile) const override;

- virtual bool ServiceIsNULLWhileTesting() const override;

+ bool ServiceIsNULLWhileTesting() const override;

};

#endif // CHROME_BROWSER_PRINTING_CLOUD_PRINT_CLOUD_PRINT_PROXY_SERVICE_FACTORY_H_