chrome/browser/printing/background_printing_manager.cc - Issue 668093002: Standardize usage of virtual/override/final in chrome/browser/printing/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/background_printing_manager.cc

Issue 668093002: Standardize usage of virtual/override/final in chrome/browser/printing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/background_printing_manager.h ('k') | chrome/browser/printing/cloud_print/cloud_print_proxy_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/background_printing_manager.cc

diff --git a/chrome/browser/printing/background_printing_manager.cc b/chrome/browser/printing/background_printing_manager.cc

index 3a891bc0e9553bb3984fe4ac63fcf8d92e36065d..daa8402d85310478520a4a452168ec8631b8a407 100644

--- a/chrome/browser/printing/background_printing_manager.cc

+++ b/chrome/browser/printing/background_printing_manager.cc

@@ -27,8 +27,8 @@ class BackgroundPrintingManager::Observer

Observer(BackgroundPrintingManager* manager, WebContents* web_contents);

private:

- virtual void RenderProcessGone(base::TerminationStatus status) override;

- virtual void WebContentsDestroyed() override;

+ void RenderProcessGone(base::TerminationStatus status) override;

+ void WebContentsDestroyed() override;

BackgroundPrintingManager* manager_;

};