Issue 668063002: exclude SyncBackendRegistrarShutdownTest.BlockingShutdown from Dr.Memory bots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 668063002: exclude SyncBackendRegistrarShutdownTest.BlockingShutdown from Dr.Memory bots (Closed)

Created:
6 years, 2 months ago by zhaoqin

Modified:
6 years, 2 months ago

Reviewers:
stanisc

CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

exclude SyncBackendRegistrarShutdownTest.BlockingShutdown from Dr.Memory bots BUG=425568 TBR=stanisc@chromium.org NOTRY=true Committed: https://crrev.com/f4efb8d1513eb996cf0f0f1f842a8c729ce2a098 Cr-Commit-Position: refs/heads/master@{#300552}

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/f4efb8d1513eb996cf0f0f1f842a8c729ce2a098 Cr-Commit-Position: refs/heads/master@{#300552}

6 years, 2 months ago (2014-10-21 20:46:20 UTC) #2

zhaoqin

Committed patchset #1 (id:1) manually as f4efb8d1513eb996cf0f0f1f842a8c729ce2a098 (presubmit successful).

6 years, 2 months ago (2014-10-21 20:46:20 UTC) #3

stanisc

This change was unnecessary because the whole change that introduced the test has already been ...

6 years, 2 months ago (2014-10-21 21:19:24 UTC) #4

zhaoqin

6 years, 2 months ago (2014-10-21 21:56:25 UTC) #6

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/674433002/ by zhaoqin@google.com.

The reason for reverting is: the excluded test
SyncBackendRegistrarShutdownTest.BlockingShutdown is removed.

Expand Messages | Collapse Messages