Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 668053003: Finish gracefully on stop events, but not on pause events. (Closed)

Created:
6 years, 2 months ago by byungchul
Modified:
6 years, 1 month ago
Reviewers:
lcwu1, gunsch
CC:
chromium-reviews, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Finish gracefully on stop events, but not on pause events. On some circumstances, pause events are generated several times during start up. Since current implementation finishes CastShellActivity on pause events, the app doesn't start unexpectedly. BUG=425812 Committed: https://crrev.com/fbda222486f52deede438cfa2a2668e0d7335931 Cr-Commit-Position: refs/heads/master@{#300714}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M net/server/http_server.cc View 1 2 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
gunsch
lgtm
6 years, 2 months ago (2014-10-22 03:41:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668053003/1
6 years, 2 months ago (2014-10-22 16:51:17 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/5224) linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/3666) linux_chromium_rel ...
6 years, 2 months ago (2014-10-22 17:01:15 UTC) #6
chromium-reviews
https://code.google.com/p/chromium/issues/detail?id=425932 On Wed, Oct 22, 2014 at 10:01 AM, <commit-bot@chromium.org> wrote: > Try jobs failed ...
6 years, 2 months ago (2014-10-22 17:04:51 UTC) #7
lcwu1
lgtm
6 years, 2 months ago (2014-10-22 17:36:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668053003/20001
6 years, 2 months ago (2014-10-22 17:41:59 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-22 18:31:22 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 18:32:45 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fbda222486f52deede438cfa2a2668e0d7335931
Cr-Commit-Position: refs/heads/master@{#300714}

Powered by Google App Engine
This is Rietveld 408576698