Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 668053002: Put chrome/ counterparts of WebView and MimeHandlerView under extensions/ (Closed)

Created:
6 years, 2 months ago by lazyboy
Modified:
6 years, 2 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Put chrome/ counterparts of WebView and MimeHandlerView under extensions/ namespace like other GuestViews. This is a cleanup only CL. Also, this CL removes one extraneous "extensions::" namespace resolution from ChromeExtensionOptionsGuestDelegate. BUG=None Test=Internal cleanup only, no visible change. Committed: https://crrev.com/0615525b39c969fc97dc281aba780477141d942f Cr-Commit-Position: refs/heads/master@{#300582}

Patch Set 1 #

Patch Set 2 : . #

Messages

Total messages: 7 (2 generated)
lazyboy
6 years, 2 months ago (2014-10-21 20:39:40 UTC) #2
Fady Samuel
lgtm
6 years, 2 months ago (2014-10-21 21:37:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668053002/20001
6 years, 2 months ago (2014-10-21 22:31:53 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-22 00:30:19 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 04:04:11 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0615525b39c969fc97dc281aba780477141d942f
Cr-Commit-Position: refs/heads/master@{#300582}

Powered by Google App Engine
This is Rietveld 408576698