Issue 66803004: rebaseline_server: improve thread locks to allow read access during updates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 66803004: rebaseline_server: improve thread locks to allow read access during updates (Closed)

Created:
7 years, 1 month ago by epoger

Modified:
6 years, 6 months ago

Reviewers:
jcgregorio

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

rebaseline_server: improve thread locks to allow read access during updates (SkipBuildbotRuns) TBR=jcgregorio Committed: https://code.google.com/p/skia/source/detail?r=12195

Patch Set 1 #

Patch Set 2 : linewrap #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -7 lines)			Patch
	M	gm/rebaseline_server/server.py	View	1	5 chunks	+14 lines, -7 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

epoger

Committed patchset #2 manually as r12195 (presubmit successful).

7 years, 1 month ago (2013-11-08 17:23:56 UTC) #1

epoger

Apologies for the TBR commit... I needed to update this asap for users of the ...

7 years, 1 month ago (2013-11-08 17:24:59 UTC) #2

jcgregorio

7 years, 1 month ago (2013-11-08 17:33:21 UTC) #3

Obviously comments are going to need to be addressed in a separate CL.

LGTM

https://codereview.chromium.org/66803004/diff/30001/gm/rebaseline_server/serv...
File gm/rebaseline_server/server.py (right):

https://codereview.chromium.org/66803004/diff/30001/gm/rebaseline_server/serv...
gm/rebaseline_server/server.py:128: # self._svn_update_lock prevents us from
updating the actual GM results
Comment seems wrong, doesn't this just prevent you from running multiple
update_results() at the same time?

https://codereview.chromium.org/66803004/diff/30001/gm/rebaseline_server/serv...
gm/rebaseline_server/server.py:182: self.results_lock = thread.allocate_lock()
Add docs here for what each lock is used for.

Expand Messages | Collapse Messages