src/objects.h - Issue 66803002: Handlify JSObject::SetElement & brethren

Unified Diff: src/objects.h

Issue 66803002: Handlify JSObject::SetElement & brethren (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: whitespace Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.h

diff --git a/src/objects.h b/src/objects.h

index 0099cb2095ec4e37a30447f0156ac96a96f5c2b0..ac17dffedc930aab8a34d6043a918fcbe6fe4d91 100644

--- a/src/objects.h

+++ b/src/objects.h

@@ -2337,22 +2337,24 @@ class JSObject: public JSReceiver {

AccessorPair* GetLocalPropertyAccessorPair(Name* name);

AccessorPair* GetLocalElementAccessorPair(uint32_t index);

- MUST_USE_RESULT MaybeObject* SetFastElement(uint32_t index,

- Object* value,

- StrictModeFlag strict_mode,

- bool check_prototype);

+ static Handle<Object> SetFastElement(Handle<JSObject> object, uint32_t index,

+ Handle<Object> value,

+ StrictModeFlag strict_mode,

+ bool check_prototype);

- MUST_USE_RESULT MaybeObject* SetDictionaryElement(

+ static Handle<Object> SetDictionaryElement(

Michael Starzinger 2013/11/13 12:24:45 It looks like this method is only used from within

rafaelw 2013/11/13 20:56:47 Done.

+ Handle<JSObject> object,

uint32_t index,

- Object* value,

+ Handle<Object> value,

PropertyAttributes attributes,

StrictModeFlag strict_mode,

bool check_prototype,

SetPropertyMode set_mode = SET_PROPERTY);

- MUST_USE_RESULT MaybeObject* SetFastDoubleElement(

+ static Handle<Object> SetFastDoubleElement(

Michael Starzinger 2013/11/13 12:24:45 Likewise.

rafaelw 2013/11/13 20:56:47 Done.

+ Handle<JSObject> object,

uint32_t index,

- Object* value,

+ Handle<Object> value,

StrictModeFlag strict_mode,

bool check_prototype = true);

@@ -2366,15 +2368,6 @@ class JSObject: public JSReceiver {

Handle<JSObject> object,

uint32_t index,

Handle<Object> value,

- PropertyAttributes attr,

- StrictModeFlag strict_mode,

- bool check_prototype = true,

- SetPropertyMode set_mode = SET_PROPERTY);

- // A Failure object is returned if GC is needed.

- MUST_USE_RESULT MaybeObject* SetElement(

- uint32_t index,

- Object* value,

PropertyAttributes attributes,

StrictModeFlag strict_mode,

bool check_prototype = true,

@@ -2391,6 +2384,11 @@ class JSObject: public JSReceiver {

kDontAllowSmiElements

};

+ static Handle<FixedArray> SetFastElementsCapacityAndLength(

+ Handle<JSObject> object,

+ int capacity,

+ int length,

+ SetFastElementsCapacitySmiMode smi_mode);

// Replace the elements' backing store with fast elements of the given

// capacity. Update the length for JSArrays. Returns the new backing

// store.

@@ -2398,6 +2396,10 @@ class JSObject: public JSReceiver {

int capacity,

int length,

SetFastElementsCapacitySmiMode smi_mode);

+ static void SetFastDoubleElementsCapacityAndLength(

+ Handle<JSObject> object,

+ int capacity,

+ int length);

MUST_USE_RESULT MaybeObject* SetFastDoubleElementsCapacityAndLength(

int capacity,

int length);

@@ -2467,6 +2469,8 @@ class JSObject: public JSReceiver {

ElementsKind to_kind);

MUST_USE_RESULT MaybeObject* TransitionElementsKind(ElementsKind to_kind);

+ static void UpdateAllocationSite(Handle<JSObject> object,

Michael Starzinger 2013/11/13 12:24:45 Likewise.

rafaelw 2013/11/13 20:56:47 Done.

+ ElementsKind to_kind);

MUST_USE_RESULT MaybeObject* UpdateAllocationSite(ElementsKind to_kind);

// TODO(mstarzinger): Both public because of ConvertAnsSetLocalProperty().

@@ -2685,23 +2689,26 @@ class JSObject: public JSReceiver {

Handle<Object> value,

Handle<JSObject> holder,

StrictModeFlag strict_mode);

- MUST_USE_RESULT MaybeObject* SetElementWithInterceptor(

+ static Handle<Object> SetElementWithInterceptor(

+ Handle<JSObject> object,

uint32_t index,

- Object* value,

+ Handle<Object> value,

PropertyAttributes attributes,

StrictModeFlag strict_mode,

bool check_prototype,

SetPropertyMode set_mode);

- MUST_USE_RESULT MaybeObject* SetElementWithoutInterceptor(

+ static Handle<Object> SetElementWithoutInterceptor(

+ Handle<JSObject> object,

uint32_t index,

- Object* value,

+ Handle<Object> value,

PropertyAttributes attributes,

StrictModeFlag strict_mode,

bool check_prototype,

SetPropertyMode set_mode);

- MUST_USE_RESULT MaybeObject* SetElementWithCallbackSetterInPrototypes(

+ static Handle<Object> SetElementWithCallbackSetterInPrototypes(

+ Handle<JSObject> object,

uint32_t index,

- Object* value,

+ Handle<Object> value,

bool* found,

StrictModeFlag strict_mode);

@@ -3965,6 +3972,11 @@ class SeededNumberDictionary

// Type specific at put (default NONE attributes is used when adding).

MUST_USE_RESULT MaybeObject* AtNumberPut(uint32_t key, Object* value);

+ MUST_USE_RESULT static Handle<SeededNumberDictionary> AddNumberEntry(

+ Handle<SeededNumberDictionary> dictionary,

+ uint32_t key,

+ Handle<Object> value,

+ PropertyDetails details);

Michael Starzinger 2013/11/13 12:24:45 nit: Indentation is off.

rafaelw 2013/11/13 20:56:47 Done.

MUST_USE_RESULT MaybeObject* AddNumberEntry(uint32_t key,

Object* value,

PropertyDetails details);

@@ -4589,6 +4601,10 @@ class ExternalByteArray: public ExternalArray {

MUST_USE_RESULT inline MaybeObject* get(int index);

inline void set(int index, int8_t value);

+ static Handle<Object> SetValue(Handle<ExternalByteArray> array,

+ uint32_t index,

+ Handle<Object> value);

// This accessor applies the correct conversion from Smi, HeapNumber

// and undefined.

MUST_USE_RESULT MaybeObject* SetValue(uint32_t index, Object* value);

@@ -4612,6 +4628,10 @@ class ExternalUnsignedByteArray: public ExternalArray {

MUST_USE_RESULT inline MaybeObject* get(int index);

inline void set(int index, uint8_t value);

+ static Handle<Object> SetValue(Handle<ExternalUnsignedByteArray> array,

+ uint32_t index,

+ Handle<Object> value);

// This accessor applies the correct conversion from Smi, HeapNumber

// and undefined.

MUST_USE_RESULT MaybeObject* SetValue(uint32_t index, Object* value);

@@ -4635,6 +4655,10 @@ class ExternalShortArray: public ExternalArray {

MUST_USE_RESULT inline MaybeObject* get(int index);

inline void set(int index, int16_t value);

+ static Handle<Object> SetValue(Handle<ExternalShortArray> array,

+ uint32_t index,

+ Handle<Object> value);

// This accessor applies the correct conversion from Smi, HeapNumber

// and undefined.

MUST_USE_RESULT MaybeObject* SetValue(uint32_t index, Object* value);

@@ -4658,6 +4682,10 @@ class ExternalUnsignedShortArray: public ExternalArray {

MUST_USE_RESULT inline MaybeObject* get(int index);

inline void set(int index, uint16_t value);

+ static Handle<Object> SetValue(Handle<ExternalUnsignedShortArray> array,

+ uint32_t index,

+ Handle<Object> value);

// This accessor applies the correct conversion from Smi, HeapNumber

// and undefined.

MUST_USE_RESULT MaybeObject* SetValue(uint32_t index, Object* value);

@@ -4681,6 +4709,10 @@ class ExternalIntArray: public ExternalArray {

MUST_USE_RESULT inline MaybeObject* get(int index);

inline void set(int index, int32_t value);

+ static Handle<Object> SetValue(Handle<ExternalIntArray> array,

+ uint32_t index,

+ Handle<Object> value);

// This accessor applies the correct conversion from Smi, HeapNumber

// and undefined.

MUST_USE_RESULT MaybeObject* SetValue(uint32_t index, Object* value);

@@ -4704,6 +4736,10 @@ class ExternalUnsignedIntArray: public ExternalArray {

MUST_USE_RESULT inline MaybeObject* get(int index);

inline void set(int index, uint32_t value);

+ static Handle<Object> SetValue(Handle<ExternalUnsignedIntArray> array,

+ uint32_t index,

+ Handle<Object> value);

// This accessor applies the correct conversion from Smi, HeapNumber

// and undefined.

MUST_USE_RESULT MaybeObject* SetValue(uint32_t index, Object* value);

@@ -4727,6 +4763,10 @@ class ExternalFloatArray: public ExternalArray {

MUST_USE_RESULT inline MaybeObject* get(int index);

inline void set(int index, float value);

+ static Handle<Object> SetValue(Handle<ExternalFloatArray> array,

+ uint32_t index,

+ Handle<Object> value);

// This accessor applies the correct conversion from Smi, HeapNumber

// and undefined.

MUST_USE_RESULT MaybeObject* SetValue(uint32_t index, Object* value);

@@ -4750,6 +4790,10 @@ class ExternalDoubleArray: public ExternalArray {

MUST_USE_RESULT inline MaybeObject* get(int index);

inline void set(int index, double value);

+ static Handle<Object> SetValue(Handle<ExternalDoubleArray> array,

+ uint32_t index,

+ Handle<Object> value);

// This accessor applies the correct conversion from Smi, HeapNumber

// and undefined.

MUST_USE_RESULT MaybeObject* SetValue(uint32_t index, Object* value);

@@ -9704,6 +9748,10 @@ class JSArray: public JSObject {

// is set to a smi. This matches the set function on FixedArray.

inline void set_length(Smi* length);

+ static void JSArrayUpdateLengthFromIndex(Handle<JSArray> array,

+ uint32_t index,

+ Handle<Object> value);

MUST_USE_RESULT MaybeObject* JSArrayUpdateLengthFromIndex(uint32_t index,

Object* value);

« no previous file with comments | « src/factory.cc ('k') | src/objects.cc » ('j') | src/objects.cc » ('J')