Handlify JSObject::SetElement & brethren

Handlify JSObject::SetElement & brethren

Because SetElement & co are interdependent, this patch handlfies all of JSObject::
-SetElement
-SetFastElement
-SetDictionaryElement
-SetFastDoubleElement
-SetElementWithInterceptor
-SetElementWithoutInterceptor
-SetElementWithCallbackSetterInPrototype

R=mstarzinger@chromium.org
LOG=N

Committed: https://code.google.com/p/v8/source/detail?r=17757

[rafaelw, 2013-11-11 18:38:13]

Ok,

This is now ready for review.

Note that I backed away from changing the calling conventions for some of the
representation-changing methods (e.g. NormalizeElements,
EnsureWritableFastElements). For reasons that aren't clear to me, making those
changes was causing non-obvious failures in tests, and I decided that it was
best left as a separate exercise.

[Michael Starzinger, 2013-11-13 12:24:45]

LGTM, just a couple of minor nits.

https://codereview.chromium.org/66803002/diff/250002/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/66803002/diff/250002/src/objects.cc#newcode11214
src/objects.cc:11214: object->GetIsolate(),
nit: Indentation is off.

https://codereview.chromium.org/66803002/diff/250002/src/objects.cc#newcode12345
src/objects.cc:12345: Handle<SeededNumberDictionary> new_dictionary;
nit: Let's merge the declaration of "new_dictionary" together with the
definition two lines below. Easier to read.

https://codereview.chromium.org/66803002/diff/250002/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/66803002/diff/250002/src/objects.h#newcode2345
src/objects.h:2345: static Handle<Object> SetDictionaryElement(
It looks like this method is only used from within JSObject. If that is the
case, then we should consider making it private (i.e. moving it down a couple of
lines into the private section).

https://codereview.chromium.org/66803002/diff/250002/src/objects.h#newcode2354
src/objects.h:2354: static Handle<Object> SetFastDoubleElement(
Likewise.

https://codereview.chromium.org/66803002/diff/250002/src/objects.h#newcode2472
src/objects.h:2472: static void UpdateAllocationSite(Handle<JSObject> object,
Likewise.

https://codereview.chromium.org/66803002/diff/250002/src/objects.h#newcode3979
src/objects.h:3979: PropertyDetails details);
nit: Indentation is off.

[rafaelw, 2013-11-13 20:56:46]

https://codereview.chromium.org/66803002/diff/250002/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/66803002/diff/250002/src/objects.cc#newcode11214
src/objects.cc:11214: object->GetIsolate(),
On 2013/11/13 12:24:45, Michael Starzinger wrote:
> nit: Indentation is off.

Done.

https://codereview.chromium.org/66803002/diff/250002/src/objects.cc#newcode12345
src/objects.cc:12345: Handle<SeededNumberDictionary> new_dictionary;
On 2013/11/13 12:24:45, Michael Starzinger wrote:
> nit: Let's merge the declaration of "new_dictionary" together with the
> definition two lines below. Easier to read.

Done.

https://codereview.chromium.org/66803002/diff/250002/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/66803002/diff/250002/src/objects.h#newcode2345
src/objects.h:2345: static Handle<Object> SetDictionaryElement(
On 2013/11/13 12:24:45, Michael Starzinger wrote:
> It looks like this method is only used from within JSObject. If that is the
> case, then we should consider making it private (i.e. moving it down a couple
of
> lines into the private section).

Done.

https://codereview.chromium.org/66803002/diff/250002/src/objects.h#newcode2354
src/objects.h:2354: static Handle<Object> SetFastDoubleElement(
On 2013/11/13 12:24:45, Michael Starzinger wrote:
> Likewise.

Done.

https://codereview.chromium.org/66803002/diff/250002/src/objects.h#newcode2472
src/objects.h:2472: static void UpdateAllocationSite(Handle<JSObject> object,
On 2013/11/13 12:24:45, Michael Starzinger wrote:
> Likewise.

Done.

https://codereview.chromium.org/66803002/diff/250002/src/objects.h#newcode3979
src/objects.h:3979: PropertyDetails details);
On 2013/11/13 12:24:45, Michael Starzinger wrote:
> nit: Indentation is off.

Done.

[rafaelw, 2013-11-14 17:30:59]

Committed patchset #15 manually as r17757 (presubmit successful).