Add a has_media flag to VolumeMetadata.

Add a has_media flag to VolumeMetadata.

The new flag carries the has_media status of a volume through from the DiskMountManager, so the information is available to chrome.fileManagerPrivate.onMountCompleted javascript listeners.

BUG=420680
Committed: https://crrev.com/7accfac4f10afbba205c87ca66a59c35775c695e
Cr-Commit-Position: refs/heads/master@{#301144}

[Steve McKay, 2014-10-22 02:15:59]

smckay@chromium.org changed reviewers:
+ smckay@chromium.org

[Steve McKay, 2014-10-22 02:16:00]

https://codereview.chromium.org/668013004/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/file_manager_private.idl (right):

https://codereview.chromium.org/668013004/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/file_manager_private.idl:282: // Flag that
specifies whether the volume contains media.
So what this is doing is exposing an existing "hasMedia" attribute? What's the
underlying heuristic for identifying media?

[Ben Kwa, 2014-10-22 17:08:32]

kenobi@chromium.org changed reviewers:
+ mkearney@chromium.org, mtomasz@chromium.org

[mtomasz, 2014-10-23 00:32:33]

On 2014/10/22 17:08:33, Ben Kwa wrote:

basically lgtm

As for the CL description please keep format:

[Title]

[Description]

BUG=

[Steve McKay, 2014-10-23 03:42:07]

LGTM.

[mkearney1, 2014-10-23 16:21:19]

lgtm

[Ben Kwa, 2014-10-23 16:26:08]

The CQ bit was checked by kenobi@chromium.org

[commit-bot: I haz the power, 2014-10-23 16:26:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/668013004/20001

[commit-bot: I haz the power, 2014-10-23 17:46:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-23 17:46:54]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Steve McKay, 2014-10-24 16:59:50]

Still LGTM. Submit!

[kenobi, 2014-10-24 17:00:04]

The CQ bit was checked by kenobi@google.com

[commit-bot: I haz the power, 2014-10-24 17:00:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/668013004/40001

[commit-bot: I haz the power, 2014-10-24 18:00:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-24 18:00:54]

Patchset 3 (id:??) landed as
https://crrev.com/7accfac4f10afbba205c87ca66a59c35775c695e
Cr-Commit-Position: refs/heads/master@{#301144}

[qyearsley, 2014-10-24 20:28:23]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/673253005/ by qyearsley@chromium.org.

The reason for reverting is: Suspected to have caused failure of test
FileManagerPrivateApiTest.Mount

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
.