Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 668013003: Use -s to pass string date to 'adb shell date' command to set date in provision. (Closed)

Created:
6 years, 2 months ago by navabi
Modified:
6 years, 2 months ago
Reviewers:
Yaron, jbudorick, zty, yfriedman
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use -s to pass string date to 'adb shell date' command to set date in provision. The 'date -u' was not working on N5 devices. The -s option seems to work across devices. I've tested on N4 and N5. BUG=406848 Committed: https://crrev.com/e3b2f5071ae50778f07abbc84fc6a9e07e169892 Cr-Commit-Position: refs/heads/master@{#300542}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/android/provision_devices.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
navabi
6 years, 2 months ago (2014-10-21 18:47:40 UTC) #2
Yaron
On 2014/10/21 18:47:40, navabi wrote: lgtm
6 years, 2 months ago (2014-10-21 18:49:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668013003/1
6 years, 2 months ago (2014-10-21 18:51:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 20:04:54 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e3b2f5071ae50778f07abbc84fc6a9e07e169892 Cr-Commit-Position: refs/heads/master@{#300542}
6 years, 2 months ago (2014-10-21 20:05:43 UTC) #7
mattm
6 years, 2 months ago (2014-10-21 21:56:57 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/667303002/ by mattm@chromium.org.

The reason for reverting is: Broke the same tests mentioned on the bug on
existing android bots, ex:
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg...
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/1...

.

Powered by Google App Engine
This is Rietveld 408576698